From nobody Thu Apr 06 13:17:06 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PshqR3Gyyz44LTj; Thu, 6 Apr 2023 13:17:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PshqR11hzz44pp; Thu, 6 Apr 2023 13:17:06 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680787027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=usPDNQAEZeJWdPsgrGc6GCBJhnqbG+8mtlyrbWTuW+k=; b=GfV4VggCGH8417tuqBOQoPrQdhu+rxGs9QjU6gXt2SRVxi8X3wSLPrO3KdjpRkcIzl9Bws R0l8me2FwKkpHwm8T4NeONr5J5lNvZzMOObmcCkDqktbun7ntYbVxxO9nPSGN1HGEvdDB4 cpU09OMZx34rAFqGjg84IdiNPSQwffi+LBMUYuAza3N5L2to4+KbMw/U4GI0nwOJD2/Whl X9ZLg+2VeKY92k4fNgBk5Z38J0Pef51ZHJHPf0ZFIw4brB9BS0YAae3s/ZcmZRViLl1SvW +YvVE6P7/8TvyPvvYVH4uzaxwqWT3tqaSZX2nu7JB8e3nZOU1zCRGWRXdvk6qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680787027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=usPDNQAEZeJWdPsgrGc6GCBJhnqbG+8mtlyrbWTuW+k=; b=OmEOibX8oSxs1V48vqhT+nNs0ZuOgFHEyPOtULMlL2X5VvWIg+MTORSZuvHR8+CK9ius48 2LZPzut+qAfgz734jx5oVpc8UY1M9Zjdc+JKJkvfJIS0jYHeALt7FgaK9nvp510jdNiWF2 zFb3CmHqYt8VhSA3vkd2AmIpKUkqywXJeidn98p9C4R8rlPZNuOcWVzNPIViMT0hTUtHGm n99W+goh3T8w/OumHF2pj5nDe7UzScD6Js3Sl8mn+Blgr+bImnzAQ+q+cjdezDD+9lt7SZ SZAJYtaMa/9m2xQxP4cOlJbZucgrvwGacCDaJYUAS5IKp0gyjVnJRZTGiHNhFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680787027; a=rsa-sha256; cv=none; b=SSpDWc2nYvwYkbyVw0nNtOE/q7DBlbIKFnq+VIMen42Wr19hf7op0ROeWotiayxa32r4EH VcrSv96Mi+x45wZj/gAaHQOB3Gt2c0RQeWLN6vGK1vggFrud5mMeBn/86QBucV+pUK8Gw0 b11Zh0R29LgCynlKu7oQ07+k2yVnZ2VtoHnePIrzpTgE8PyXbP1Ot5B+SiMFmVxx0YVZ5X EIS8z4QaiCDZCXxs4TA3LsWqGJ9mjtVZfzYdQOAn7ahO9urZdODGQHSwJiTzf/5veWKC1J jDRPomJU5KHlmRfy8yT6Zk77gwruX/0p4lVGiExFYsKUhDwS07iPafhGGMDu3g== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 6E5E01F00A; Thu, 6 Apr 2023 13:17:06 +0000 (UTC) Date: Thu, 6 Apr 2023 13:17:06 +0000 From: Alexey Dokuchaev To: Guido Falsi Cc: Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 72ad532057c9 - main - archivers/zstd: Add CMake config files and adjust Makefile Message-ID: References: <202304050615.3356FKNq062154@gitrepo.freebsd.org> <7accd096-7871-29ad-0824-c035504d01b0@FreeBSD.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7accd096-7871-29ad-0824-c035504d01b0@FreeBSD.org> X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote: > On 05/04/23 08:15, Daniel Engberg wrote: > > commit 72ad532057c9f9fb6fa370c80f663c005e9dd021 > > > > archivers/zstd: Add CMake config files and adjust Makefile > > > > - Use upstream's short test for "make test" > > - Use verbose output by default during build > > * Tweak Makefile to follow Porters Handbook more closely > > * Install CMake files (taken from CMake build framework) > > > > PR: 267652 > > Reported by: fluffy > > Approved by: portmgr (maintainer timeout, 1+ month) > > Looks like this, un[luckily], causes a failure with devel/qt6-base > (abridged error, full log if needed): > > ld: error: relocation R_X86_64_32 cannot be used against local symbol; > recompile with -fPIC > >>> defined in /usr/local/lib/libzstd.a(zstd_common.o) > >>> referenced by zstd_common.c > >>> zstd_common.o:(ZSTD_versionString) in archive Yeah, I'm seeing this as well. Admittedly, the whole commit looks dubious to me, with all these out-of-blue new files and gratuitous changes. I guess sunpoet@ should revert it and merge only needed parts thereof properly. ./danfe