Re: git: 09c8b6c737f2 - main - games/powder-toy: Use USES=luajit (defaults to luajit-devel)

On Sun, Oct 16, 2022 at 5:07 PM Dmitry Marakasov <amdmi3@amdmi3.ru> wrote:

> * Adam Weinberger (adamw@FreeBSD.org) wrote:
>
> > diff --git a/games/powder-toy/Makefile b/games/powder-toy/Makefile
> > index 9f3669ed3c41..83404aceaedb 100644
> > --- a/games/powder-toy/Makefile
> > +++ b/games/powder-toy/Makefile
> > @@ -1,6 +1,7 @@
> >  PORTNAME=    powder-toy
> >  PORTVERSION= 96.2.350
> >  DISTVERSIONPREFIX=   v
> > +PORTREVISION=        1
> >  CATEGORIES=  games
> >
> >  MAINTAINER=  amdmi3@FreeBSD.org
> > @@ -13,14 +14,13 @@ LICENSE_FILE=     ${WRKSRC}/LICENSE
> >
> >  LIB_DEPENDS= libfftw3f.so:math/fftw3-float \
> >               libfftw3.so:math/fftw3 \
> > -             libluajit-5.1.so:lang/luajit-openresty \
> >               libcurl.so:ftp/curl
> >
> >  USE_GITHUB=  yes
> >  GH_ACCOUNT=  The-Powder-Toy
> >  GH_PROJECT=  The-Powder-Toy
> >
> > -USES=                compiler:c++11-lang meson pkgconfig python:build
> sdl
> > +USES=                compiler:c++11-lang luajit meson pkgconfig
> python:build sdl
> >  USE_SDL=     sdl2
> >
> >  PORTDOCS=    README.md changelog.txt
>
> This change is invalid, as it changes dependency from luajit-openresty
> to luajit-devel. Please revert or change it to depend on openresty, as
> luajit is broken and leads to segfaults. Same for minetest, for the
> record.
>

Done. Strange that they behave badly; Powder Toy's repo links specifically
to luajit-devel's repo, and minetest says that it works with luajit 2.0+.

That's the unfortunate part of the luajit fragmentation that we have in the
tree. Because lang/luajit is so old, it's not clear whether a
luajit-openresty dep means "this requires openresty" vs "I don't want to
depend on the old version." They all compile cleanly, so I tried to use
upstreams to guide the conversion.

# Adam


-- 
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.org
https://www.adamw.org