From nobody Mon Oct 17 01:18:15 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MrJzD5gp8z4fNN7 for ; Mon, 17 Oct 2022 01:18:32 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MrJzD4yssz3mMp for ; Mon, 17 Oct 2022 01:18:32 +0000 (UTC) (envelope-from adamw@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665969512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MWJsiAag+EvyhKdeDUpYpBK9PSBxhFmnM8k2Ufwpt4I=; b=dWz7DWOjS+W56ytSawY1piXD1gh+O2t5EnDFrZdcnDOBKvQTxnFtASuQ7hIEphm2xerFtH 4jCVQLw8neMFnJTbiwDBjIBesJuHFJobS9ku4zzB8JXy9CDhR+wzIB0qhGeiVLVrxf09Sv fT83xmo9mm6SPkNxkjA+Bv3qI9bAESmbE7uM88+k9PCrX0lr1w12Z0qrfMmu91gE6xK1Yk opiZnNcehIPLFF/Xr9/D8p1xYx41HAb3kmrhu/DggoG9BAcF/E1KapqxpXbkt/fYZptfTQ 86pdtC+l/tRKcNNcVMwtmpa5OV+l0gxYFSJwNbSt9c8PKxnAkOdPI2mdoNiVBw== Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: adamw/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MrJzD3nkJz1R2k for ; Mon, 17 Oct 2022 01:18:32 +0000 (UTC) (envelope-from adamw@freebsd.org) Received: by mail-ed1-f44.google.com with SMTP id u21so13950799edi.9 for ; Sun, 16 Oct 2022 18:18:32 -0700 (PDT) X-Gm-Message-State: ACrzQf0d42i+zZ+3JU/cWJJEDkcMPvGrFwkZZ72T00pvj0zve3biE7Ap sErxf4tFq26Mf6I9lCAZDSKcQ/jbtbgMELbaju8+0A== X-Google-Smtp-Source: AMsMyM4a5ZsWPtN87h7wcoQuTHfyQIyIGi92nOYWMgsFiJo63OfClmHqi+FBFG+CO3MvTfCGmAw9akiyubig/XuVNKk= X-Received: by 2002:a50:fe0a:0:b0:458:dce8:2b6b with SMTP id f10-20020a50fe0a000000b00458dce82b6bmr7906243edt.84.1665969511272; Sun, 16 Oct 2022 18:18:31 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202210150120.29F1KoYq034805@gitrepo.freebsd.org> In-Reply-To: From: Adam Weinberger Date: Sun, 16 Oct 2022 19:18:15 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 09c8b6c737f2 - main - games/powder-toy: Use USES=luajit (defaults to luajit-devel) To: Dmitry Marakasov Cc: Adam Weinberger , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000ed2c6705eb30c0e1" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665969512; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MWJsiAag+EvyhKdeDUpYpBK9PSBxhFmnM8k2Ufwpt4I=; b=dnjezvy8Kq/0GbxQ9rwDx/eJT7JSJyx++OxUQEKDX2kKrNePSKhIYKqnxLFZsDC6cQ9LxB 4SFysPa2MlS22M3+PreX13zEJYsDObb/GLaWQI5+oD02foFoZh3+r+LZXWtSg47tx7/44T L9KlLjrGBRyhRRg4MU8ScrahLE78CzG5gdExFImqjH8f+r5rEl+YHDnukoZ0wIGTrA5eNT IY1yPrl849bJV3tudmrK2CHHQA2GEMHQ2x/pyngxcn6ZIW2HOP6nAMhP5A4CurFWkCHRoW NcuN301qdVO51O/pf9yFOCasyhbd/4yzVPFQT8EB5HnjIqHnUOUAQ9jJ0Kh2ng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665969512; a=rsa-sha256; cv=none; b=uSCsrz3aQQWFgQkD791YqyDoq2NFPnwN5100X22w+v40sI6w4fxpjaCyYFTpn4jCCwInp6 S08YMxKXPzWqtquTNM445A9xA9VpBzyGWxr4Bp/y6DIlVEVjQkcR3sVdnGztQwG8Z3UxPY vjpJ5KxeWq7kDHtr5SHqoZJRHaycbKDURZL+726aYPL4gNtNekPJ9bZkFfTyCOB0P5M7In FyQhBbw/xMzEsGezHoRze8t7yvtxv/XVDH+YR+HVHFpTOiURxtHj/M4JIXt86mSljPV8fE VRFBO/azcJ9lplfWswCxgtpV/4NMGVDaqKU4Ab72B0Hnips8sUv41j1m/HS5jw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --000000000000ed2c6705eb30c0e1 Content-Type: text/plain; charset="UTF-8" On Sun, Oct 16, 2022 at 5:07 PM Dmitry Marakasov wrote: > * Adam Weinberger (adamw@FreeBSD.org) wrote: > > > diff --git a/games/powder-toy/Makefile b/games/powder-toy/Makefile > > index 9f3669ed3c41..83404aceaedb 100644 > > --- a/games/powder-toy/Makefile > > +++ b/games/powder-toy/Makefile > > @@ -1,6 +1,7 @@ > > PORTNAME= powder-toy > > PORTVERSION= 96.2.350 > > DISTVERSIONPREFIX= v > > +PORTREVISION= 1 > > CATEGORIES= games > > > > MAINTAINER= amdmi3@FreeBSD.org > > @@ -13,14 +14,13 @@ LICENSE_FILE= ${WRKSRC}/LICENSE > > > > LIB_DEPENDS= libfftw3f.so:math/fftw3-float \ > > libfftw3.so:math/fftw3 \ > > - libluajit-5.1.so:lang/luajit-openresty \ > > libcurl.so:ftp/curl > > > > USE_GITHUB= yes > > GH_ACCOUNT= The-Powder-Toy > > GH_PROJECT= The-Powder-Toy > > > > -USES= compiler:c++11-lang meson pkgconfig python:build > sdl > > +USES= compiler:c++11-lang luajit meson pkgconfig > python:build sdl > > USE_SDL= sdl2 > > > > PORTDOCS= README.md changelog.txt > > This change is invalid, as it changes dependency from luajit-openresty > to luajit-devel. Please revert or change it to depend on openresty, as > luajit is broken and leads to segfaults. Same for minetest, for the > record. > Done. Strange that they behave badly; Powder Toy's repo links specifically to luajit-devel's repo, and minetest says that it works with luajit 2.0+. That's the unfortunate part of the luajit fragmentation that we have in the tree. Because lang/luajit is so old, it's not clear whether a luajit-openresty dep means "this requires openresty" vs "I don't want to depend on the old version." They all compile cleanly, so I tried to use upstreams to guide the conversion. # Adam -- Adam Weinberger adamw@adamw.org // adamw@FreeBSD.org https://www.adamw.org --000000000000ed2c6705eb30c0e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Sun, Oct 16, 2022 at 5:07 PM Dmitry= Marakasov <amdmi3@amdmi3.ru>= wrote:
* Adam W= einberger (adamw@FreeBSD.org) wrote:

> diff --git a/games/powder-toy/Makefile b/games/powder-toy/Makefile
> index 9f3669ed3c41..83404aceaedb 100644
> --- a/games/powder-toy/Makefile
> +++ b/games/powder-toy/Makefile
> @@ -1,6 +1,7 @@
>=C2=A0 PORTNAME=3D=C2=A0 =C2=A0 powder-toy
>=C2=A0 PORTVERSION=3D 96.2.350
>=C2=A0 DISTVERSIONPREFIX=3D=C2=A0 =C2=A0v
> +PORTREVISION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 1
>=C2=A0 CATEGORIES=3D=C2=A0 games
>=C2=A0
>=C2=A0 MAINTAINER=3D=C2=A0 amdmi3@FreeBSD.org
> @@ -13,14 +14,13 @@ LICENSE_FILE=3D=C2=A0 =C2=A0 =C2=A0${WRKSRC}/LICEN= SE
>=C2=A0
>=C2=A0 LIB_DEPENDS=3D libfftw3f.so:math/fftw3-float \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libfftw3.so:math= /fftw3 \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libluajit-5.1.so:lang= /luajit-openresty \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libcurl.so:ftp/c= url
>=C2=A0
>=C2=A0 USE_GITHUB=3D=C2=A0 yes
>=C2=A0 GH_ACCOUNT=3D=C2=A0 The-Powder-Toy
>=C2=A0 GH_PROJECT=3D=C2=A0 The-Powder-Toy
>=C2=A0
> -USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compil= er:c++11-lang meson pkgconfig python:build sdl
> +USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compil= er:c++11-lang luajit meson pkgconfig python:build sdl
>=C2=A0 USE_SDL=3D=C2=A0 =C2=A0 =C2=A0sdl2
>=C2=A0
>=C2=A0 PORTDOCS=3D=C2=A0 =C2=A0 README.md changelog.txt

This change is invalid, as it changes dependency from luajit-openresty
to luajit-devel. Please revert or change it to depend on openresty, as
luajit is broken and leads to segfaults. Same for minetest, for the
record.

Done. Strange that they behave badly; Powde= r Toy's repo links specifically to luajit-devel's repo, and minetes= t says that it works with luajit 2.0+.

That's the unfortunate part of = the luajit fragmentation that we have in the tree. Because lang/luajit is s= o old, it's not clear whether a luajit-openresty dep means "this r= equires openresty" vs "I don't want to depend on the old vers= ion." They all compile cleanly, so I tried to use upstreams to guide t= he conversion.

# Adam


--
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.org
https://www.adamw.org
--000000000000ed2c6705eb30c0e1--