Re: git: bec21c95d998 - main - Tools/scripts: remove addport

On Tue, May 10, 2022 at 01:23:39PM +0200, Alexander Leidinger wrote:
> Quoting "Tobias C. Berner" <tcberner@freebsd.org> (from Tue, 10 May 2022
> 09:41:16 +0200):
> 
> > Moin moin
> > 
> > 
> > On Tue, 10 May 2022 at 08:34, Alexander Leidinger
> > <Alexander@leidinger.net> wrote:
> > > 
> > > Quoting Rene Ladan <rene@freebsd.org> (from Mon, 9 May 2022 19:06:33 GMT):
> > > 
> > > > The branch main has been updated by rene:
> > > >
> > > > URL:
> > > > https://cgit.FreeBSD.org/ports/commit/?id=bec21c95d998ff28ef8a8337cec3b9fce8074ce8
> > > >
> > > > commit bec21c95d998ff28ef8a8337cec3b9fce8074ce8
> > > > Author:     Rene Ladan <rene@FreeBSD.org>
> > > > AuthorDate: 2022-04-30 19:53:22 +0000
> > > > Commit:     Rene Ladan <rene@FreeBSD.org>
> > > > CommitDate: 2022-05-09 19:06:06 +0000
> > > >
> > > >     Tools/scripts: remove addport
> > > >
> > > >     The addport script is no longer useful since git has been
> > > introduced in
> > > 
> > > Why?
> > > 
> > > Git is not different compared to even CVS in what the script helped to
> > > do (automate the sorted insertion into the category Makefile and
> > > validating a few aspects of before commit). IT helps preventing
> > > mistakes for people which rarely add a new port.
> > git supports hooks, and we have a hook for that :) -- if you enable
> > the hooks, you cannot even commit without adding SUBDIR to the
> > category-Makefile.
> 
> Does the hook doesn't automate it like addport did? From your desription it
> sounds like it doesn't. So why removing addport? Was it broken?
> 
> Bye,
> Alexander.

addport has never been ported to git in the first place, it was useful becaue of
the centralized nature of svn and CVS before that, where if we prevented the
commit like we do prevent the push in git right now the committer would have to
redo the entire commit.

In the git world when the push fails with the explicit message, then the
committed just have to amend to his already done commit, so the pain of being
blocked by the hook becomes way less significant.

The fact that noone even tried to convert the script to git also shows the
little interest of this script by the community of committers since the
conversion.

Because of all those reasons it has been decided that it was not worth
maintaining such a script for the very very little gain it provides.

Best regards,
Bapt