From nobody Tue May 10 11:42:41 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1B6861AD1105; Tue, 10 May 2022 11:42:44 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KyGPJ0F8Kz4rJW; Tue, 10 May 2022 11:42:44 +0000 (UTC) (envelope-from bapt@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652182964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9Zfpk5ymU0IruvFOQ0xi8UwgVk2ROW6e1HbpPkJ1/4=; b=PILomtbi+e+clThnDkMehrZgQp9Vfo8KxWh4UnSmRdYVrW9yR/7omhdlVumuGFVw9NCUQG /v1kcafPNTzr6/Oc6k2x2YDH/SA5qiHrJajDVfyTWtYSVDIgTQ/w5e4UUjh0YAJiRAory5 FbuXTJawT5B6j1SBGWeE6enIFSRAD7doJQzMAXzPbmbuQwzmbvgb42XS/EHovGK2mcOGOj FRrfpoSxWVHIlZXiPGWds62lmhjRf7RNqn1V9JyzuUUShzf5eHV0L2BS86FEktJ9zk1Bhh wJdFyHVtP106vfTj1+YKtvSWoYeU+YobSf6Oq82sVzEfU60PprgOgmwD6fP3ZA== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id C382D20B60; Tue, 10 May 2022 11:42:43 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 2192159F95; Tue, 10 May 2022 13:42:41 +0200 (CEST) Date: Tue, 10 May 2022 13:42:41 +0200 From: Baptiste Daroussin To: Alexander Leidinger Cc: "Tobias C. Berner" , Rene Ladan , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bec21c95d998 - main - Tools/scripts: remove addport Message-ID: <20220510114241.cxb2hqvku2bv3l3w@aniel.nours.eu> References: <202205091906.249J6XtT058493@gitrepo.freebsd.org> <20220510083350.Horde.F3d0pvlHg8AlBb6sDH2VvEd@webmail.leidinger.net> <20220510132339.Horde.3XAzaNdcmbZX3auZE5ic7po@webmail.leidinger.net> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220510132339.Horde.3XAzaNdcmbZX3auZE5ic7po@webmail.leidinger.net> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652182964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v9Zfpk5ymU0IruvFOQ0xi8UwgVk2ROW6e1HbpPkJ1/4=; b=u+OdirdPOFK9ChxyZfGUPee62dur0NpDUHS3UKlEnii1vZVeL6U/j5phri5muYzkv+/9qk 1Tp6LFAoEnlGiuBuGCL+BCcJAMUPpFtZFHqlcKrafy+fcVCrdYpvuQhEglupxyocbVCi4m 2rFVE3zzu+w6cypkepTSMZ94s/Zr7KI0K/GDL8QiYy5Yg7ol3mitm+VNIPH0D1CTnypEtf ipp4YhYDqX5fbJD2aa7UB+2YwkHTX1I6Iq15yJHRiFcaOit8yd8S3YdOhZvrI4s2GzcZ1S kLdwolwDxdFl1/ekIH+9gLnIl1WNq+AuYz7rSKFjG+Djv/URJnoy2iknW4aNNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652182964; a=rsa-sha256; cv=none; b=HZ4B4Zd8MrXCB+fV4q2809NT2zdjrtiWSDwA/m7lvRxhHdD/vOcrI+s4DSeB64ESefYJ6h vKBFk//V3ZxfHVc1944HU+PUTWJvLfvV1h3qG3UjEPt57Zcmc2Ug0g0Q9c9r/Vt2UrPpTc 9MnWF6AcktRTelYS3HYjaAB2DP0W2YpwjUIV5YDUqY6xXUC1DuEfT46jlQx+Bfw0LiEZiJ e7DvA1F4r3vhZeY7IyeYtfyfbv05KTWNhRACiPKh0L7sTQAjJ8zGYlhFSmRLn13Sma75Gc Eo33y+rGPXm0Rf8fbmCyvlWDJYELLs9aBNHyge7anHVX5BJUdYfCTjLPWIG8TQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, May 10, 2022 at 01:23:39PM +0200, Alexander Leidinger wrote: > Quoting "Tobias C. Berner" (from Tue, 10 May 2022 > 09:41:16 +0200): > > > Moin moin > > > > > > On Tue, 10 May 2022 at 08:34, Alexander Leidinger > > wrote: > > > > > > Quoting Rene Ladan (from Mon, 9 May 2022 19:06:33 GMT): > > > > > > > The branch main has been updated by rene: > > > > > > > > URL: > > > > https://cgit.FreeBSD.org/ports/commit/?id=bec21c95d998ff28ef8a8337cec3b9fce8074ce8 > > > > > > > > commit bec21c95d998ff28ef8a8337cec3b9fce8074ce8 > > > > Author: Rene Ladan > > > > AuthorDate: 2022-04-30 19:53:22 +0000 > > > > Commit: Rene Ladan > > > > CommitDate: 2022-05-09 19:06:06 +0000 > > > > > > > > Tools/scripts: remove addport > > > > > > > > The addport script is no longer useful since git has been > > > introduced in > > > > > > Why? > > > > > > Git is not different compared to even CVS in what the script helped to > > > do (automate the sorted insertion into the category Makefile and > > > validating a few aspects of before commit). IT helps preventing > > > mistakes for people which rarely add a new port. > > git supports hooks, and we have a hook for that :) -- if you enable > > the hooks, you cannot even commit without adding SUBDIR to the > > category-Makefile. > > Does the hook doesn't automate it like addport did? From your desription it > sounds like it doesn't. So why removing addport? Was it broken? > > Bye, > Alexander. addport has never been ported to git in the first place, it was useful becaue of the centralized nature of svn and CVS before that, where if we prevented the commit like we do prevent the push in git right now the committer would have to redo the entire commit. In the git world when the push fails with the explicit message, then the committed just have to amend to his already done commit, so the pain of being blocked by the hook becomes way less significant. The fact that noone even tried to convert the script to git also shows the little interest of this script by the community of committers since the conversion. Because of all those reasons it has been decided that it was not worth maintaining such a script for the very very little gain it provides. Best regards, Bapt