Re: git: bd12c83965dd - main - net/boinc_curses: adopt, portfmt

On 08/10/2022 3:20 pm, Alexey Dokuchaev wrote:
> On Wed, Aug 10, 2022 at 03:07:37PM -0500, Larry Rosenman wrote:
>> On 08/10/2022 12:47 pm, Alexey Dokuchaev wrote:
>> > On Wed, Aug 10, 2022 at 05:41:43PM +0000, Larry Rosenman wrote:
>> >> From: Alexey Dokuchaev <danfe@freebsd.org>
>> >> > ...
>> >> > Just wondering what's the rationale for this change?  Previously 'twas
>> >> > one perfectly readable line which fit the ~80 char terminal width with
>> >> > some extra slack.  We do wrap overly long lines, but why here?
>> >>
>> >> Portfmt did it. Not sure [about] rationale.
>> >
>> > Looks like a bug in portfmt.  FWIW it's just a linting tool, and thus
>> > its advice should not be followed blindly.
>> 
>> What major difference does it make?
> 
> It breaks up short enough line in two for no apparent reason.  This is
> gratuitous change of dubious value which clutters commit diff and makes
> blaming a bit harder.
> 
>> the port works, and portfmt makes it somewhat cleaner.
> 
> I'm not saying that *all* of its suggestions are wrong^Wstrange and/or
> uncalled for, just this particular one.
> 
> ./danfe
then file a bug against portfmt.

-- 
Larry Rosenman                     http://people.freebsd.org/~ler
Phone: +1 214-642-9640                 E-Mail: ler@FreeBSD.org
US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106