From nobody Wed Aug 10 20:21:52 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M31Ys5WJ8z4YBRB; Wed, 10 Aug 2022 20:21:53 +0000 (UTC) (envelope-from ler@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M31Ys542Hz3tln; Wed, 10 Aug 2022 20:21:53 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660162913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3PA+Wgy9qpMK6HovCLNti1WM/WDtrTk2DgT7vmdtKA0=; b=bLfwogJPm1XKeb78RERgRgxCZcXKOUxZ0F8unXWUsq5FMHBwzjRIuoWrFNeP+alq/s9IOh FEuIfPPMD0UF6GjfOxe0mE0aoIDBlHzfHc+FhwQBA7EWoqvwwRFjXltEl1oimiR1tDJppe V29GkLWKH8tEXtpPi69CRMdHORRwdHON1nJhmsGdSYwGCq/pwlYnUp7SsivE/qZWOEZkYR kfu40lcHBFV6EHmSToCdHirMxG1cFclt8q9WQ/Tp/kzdSXLfQLIXSx92Cpc3E2GE4ggm8m sdNnrJEG1KkiiMEnaMtk1NXxOsCnwodnQtUhDiR/H+FLm6r8g4qx1A63EwETOQ== Received: from thebighonker.lerctr.org (thebighonker.lerctr.org [IPv6:2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "R3" (verified OK)) (Authenticated sender: ler/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M31Ys41Wszb40; Wed, 10 Aug 2022 20:21:53 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3PA+Wgy9qpMK6HovCLNti1WM/WDtrTk2DgT7vmdtKA0=; b=Nf2Z+BbapTTuBXpWrufhEB2Kq1 CNQlO9Uu+LVvWneBLkr/a+QF9tZTI1zxWE8gI06/y+nV+4hQSqTJXVOGtInl6EA809xnX8ttextPd I734Tu3P4JQMginr3vTbgvnvGGuaZYCvILlnwiHA+0XD0ilwqhn4CSZCMnFeRF2xOPdApieKjgvLf g02Ft149NJuViuVQ7QR/lxokDT8QkaG3Seuhl97RsCOdW8kyzzrt5EXV3yGh8OsOKPaZzIcug6SwW Z4Ls47aD/ZMqNv7PfY1MRe/7LqGSxIj+lznkoNYOHvPCEJgDCwvp3wPTxUalweWlsh89YYIzN2PFm +P3l/Sjw==; Authentication-Results: thebighonker.lerctr.org; iprev=pass (thebighonker.lerctr.org) smtp.remote-ip=2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4; auth=pass (LOGIN) smtp.auth=ler@lerctr.org; spf=softfail smtp.mailfrom=FreeBSD.org; dmarc=skipped header.from=FreeBSD.org; arc=none Received-SPF: softfail (thebighonker.lerctr.org: transitioning domain of FreeBSD.org does not designate 2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4 as permitted sender) client-ip=2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4; envelope-from=ler@FreeBSD.org; helo=webmail.lerctr.org; Received: from thebighonker.lerctr.org ([2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4]:40317 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95 (FreeBSD)) (envelope-from ) id 1oLsDA-000KXR-Hh; Wed, 10 Aug 2022 15:21:52 -0500 Received: from 2600:1700:210:b18f:61a2:6e86:adba:e1a8 by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Wed, 10 Aug 2022 15:21:52 -0500 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Date: Wed, 10 Aug 2022 15:21:52 -0500 From: Larry Rosenman To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bd12c83965dd - main - net/boinc_curses: adopt, portfmt In-Reply-To: References: <202208101705.27AH5Ucm054259@gitrepo.freebsd.org> Message-ID: X-Sender: ler@FreeBSD.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660162913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3PA+Wgy9qpMK6HovCLNti1WM/WDtrTk2DgT7vmdtKA0=; b=n+g8Ct2l6k/ftI7nD9oMUwOnqCg9O/8BQnKCnZWqayyyY6BgnpVPQaychmpONBgLdAluDi 16ZgJOq6Dd9Y+XBEtpaHZUGbDCOw/YIL9lujvMKzwH5B3mYap6a/O8guki75/FpDDNCxaR t6mWzElJRbld0qQNPKVEhJLpM5N+ptOPCVMx4MSDmu+DWYvPD+I/Bun/NYEuWkd1kNYiuR pTxz/pcj35+4RfmkrMaYro/6Kth3dH884GVBIrXST+3WOqawnH8YbLDBtU4Wol8mjVr+C2 cuN7LtoLV+1y4Ml+haeZvccLn81i0RcSJsTF5F9QRRa6c5Lc1bCgRT8YvlL1cA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660162913; a=rsa-sha256; cv=none; b=jfrlxyO2n6c8lx7Fp07E8DXsG3mOMHqVLR1Eq4WfazCxGW0EMEvP0IUWmsPBULWf3rebq1 csjJqykf6djjOkuocciD1xUWf75PXlGgD3g3d70+tgZlKBW07fD85y2Ev80czSQ5hmuNi5 RMXMrq6G4PSX3wvKHN6CglcdQY63UpDt8S8opG5u1Rwz05CiL7fcGJD2OxhTWuBvXfCL1f zc3awFvJZg2AiXl2X3nvXGxCVLHxr7pAsmIeinKSxg82bpYKXLdN9ODEwrFsfx3Hj0hps8 omtBCXzsMlxEFJ2JIXHv8kRtf2ArCW6UZMB71FS285YIG0jDpXX4S2uG36ywrg== ARC-Authentication-Results: i=1; thebighonker.lerctr.org; iprev=pass (thebighonker.lerctr.org) smtp.remote-ip=2602:fcdb:0:10:7ae3:b5ff:fe1b:23b4; auth=pass (LOGIN) smtp.auth=ler@lerctr.org; spf=softfail smtp.mailfrom=FreeBSD.org; dmarc=skipped header.from=FreeBSD.org; arc=none X-ThisMailContainsUnwantedMimeParts: N On 08/10/2022 3:20 pm, Alexey Dokuchaev wrote: > On Wed, Aug 10, 2022 at 03:07:37PM -0500, Larry Rosenman wrote: >> On 08/10/2022 12:47 pm, Alexey Dokuchaev wrote: >> > On Wed, Aug 10, 2022 at 05:41:43PM +0000, Larry Rosenman wrote: >> >> From: Alexey Dokuchaev >> >> > ... >> >> > Just wondering what's the rationale for this change? Previously 'twas >> >> > one perfectly readable line which fit the ~80 char terminal width with >> >> > some extra slack. We do wrap overly long lines, but why here? >> >> >> >> Portfmt did it. Not sure [about] rationale. >> > >> > Looks like a bug in portfmt. FWIW it's just a linting tool, and thus >> > its advice should not be followed blindly. >> >> What major difference does it make? > > It breaks up short enough line in two for no apparent reason. This is > gratuitous change of dubious value which clutters commit diff and makes > blaming a bit harder. > >> the port works, and portfmt makes it somewhat cleaner. > > I'm not saying that *all* of its suggestions are wrong^Wstrange and/or > uncalled for, just this particular one. > > ./danfe then file a bug against portfmt. -- Larry Rosenman http://people.freebsd.org/~ler Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106