Is 'zpool clear' supposed to work in case when pool I/O is suspended?

[Matthew Ahrens]

Sorry this email slipped off my radar.  Hopefully this info is still
relevant to you.

This was mistakenly changed with the libzfs_core push.  It was fixed in the
following illumos commit:

https://www.illumos.org/issues/4080

commit 22e30981d82a0b6dc89253596ededafae8655e00
Author: George Wilson <george.wilson at delphix.com>
Date:   Thu Aug 29 10:56:49 2013 -0800

    3954 metaslabs continue to load even after hitting zfs_mg_alloc_failure
limit
    4080 zpool clear fails to clear pool
    4081 need zfs_mg_noalloc_threshold
    Reviewed by: Adam Leventhal <ahl at delphix.com>
    Reviewed by: Matthew Ahrens <mahrens at delphix.com>
    Approved by: Richard Lowe <richlowe at richlowe.net>

--matt


On Wed, Jul 24, 2013 at 10:04 PM, Xin Li <delphij at delphij.net> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hi, Matthew,
>
> Looking at zfs_ioc_clear(), it seems like we wanted to use it as a way
> of waking up the pool from suspended I/O:
>
> %%%
>         /*
>          * Resume any suspended I/Os.
>          */
>         if (zio_resume(spa) != 0)
>                 error = SET_ERROR(EIO);
>
>         spa_close(spa, FTAG);
> %%%
>
> However, it's marked as POOL_CHECK_SUSPENDED:
>
> %%%
>         zfs_ioctl_register_pool(ZFS_IOC_CLEAR, zfs_ioc_clear,
>             zfs_secpolicy_config, B_TRUE, POOL_CHECK_SUSPENDED);
> %%%
>
> And the change was introduced in Illumos revision 4445fffb
> (libzfs_core).  Is this part intentional?  Before this it was
> POOL_CHECK_NONE.
>
> Cheers,
> - --
> Xin LI <delphij at delphij.net>    https://www.delphij.net/
> FreeBSD - The Power to Serve!           Live free or die
> -----BEGIN PGP SIGNATURE-----
>
> iQEcBAEBCgAGBQJR8DMxAAoJEG80Jeu8UPuzpLcH/iZD7lkMyvEaKrzs37UgqPHH
> +gxvqozX9U620Bog8IQ+vKsV+8G6zWpFWfLb3OhNewNJwgojynaRShToPwr70sBR
> 72SuJ8LaUq4FafgOPQhJRyLHYnvF4986S93JIgOuHprzRFhWsLzBP8OSaKrfbAFp
> 89YE8EIMoc91L+c6gvGcfcDAdb25J4xeRlv4ZLeUf6pMmQ6IRnoZ15XrKhkT9J8b
> ZRNQO1g6Xy3Ub8XjxuANAVLH+lUq8APKBhoQO82vsfVgnm6U4U4o1MKDI2ooV/94
> hf+bwPZ/p63z9b5cf0wrI1B6lZ06JBjp8WTf7DbufhNik6Kg+orlYvaMyVt9kMk=
> =bBCp
> -----END PGP SIGNATURE-----
>