[OpenZFS Developer] a ZFS SA bug and my patch

[Ned Bass]

Hi James,

On Fri, Nov 22, 2013 at 07:27:19AM -0800, James Pan wrote:
> Hi Ned,
> Thanks very much for your comments.
> Actually 'done' is not necessary and can be completely removed.
> The value of *will_spill is initialized only when buftype is SA_BONUS, so to
> remove buftype == SA_BONUS from the check, we need to set it to False for
> SA_SPILL buftype as well.
> 
> I've revised the patch to reflect these changes, could you help review it again
> and get it checked in to the main branch if it is OK?
> Thanks a lot.

It looks good to me, except for a couple of formatting issues noted
below.  We'll get it tested in the Linux port and post results.  I'm not
an upstream ZFS maintainer so I can't check it in.  This is a link to
the official integration process, but for now you probably just need to
stand by for responses from the senior Illumos folks.

http://open-zfs.org/wiki/Illumos_integration_process

+                       /* 
+                        * Don't worry that the spill block will get overflowed,
+                         * we will resize it later in sa_build_layouts().
+                        */

  Remove trailing whitespace and align *.

+                       if (buftype == SA_SPILL || 

  Remove trailing whitespace.

+                                * Record the extra header size in case this increase needs

  Wrap line to 80 columns.

Thanks,
Ned