STF ZFS test suite, part 2

[Steven Hartland]

----- Original Message ----- 
From: <asomers at gmail.com>

>> This appears to be an issue with using /tmp as the target dir, using another
>> directory and I can run the import without issue it seems. Other tests also
>> hang with the same issue:-
>> zpool_upgrade_002_pos
>> zpool_upgrade_003_pos
>> zpool_upgrade_007_pos
>> zpool_upgrade_008_pos
>> zpool_upgrade_009_neg
>>
>> Would it be an issue to change the directory?
> 
> You should be able to use any output directory at all.  Also, I
> usually put TMPDIR on its own UFS filesystem because it makes the
> hotspare tests go faster.

I've confirmed changing the default TMPDIR fixes ths issue. I believe
the problem is in /tmp there's some fifo's, so possibly some bad
interaction with those, that and I'm sure its not a good idea to mount
a pool over the main system tmp directory ;-)

>>>> 5. Pretty much all the cache & clean_mirror tests fail, again expected?
>>>
>>>
>>> Not expected.  I think that the cache tests have a bug that makes them
>>> fail if you're only running with one disk.  With more disks, they
>>> should pass.  Over here, they all pass except for cache_009_pos.
>>>

The problem with cache tests is they use the shell function
is_physical_device which is using a hard coded list of device names
it considers a physical devices, this doesn't match our devices.

Possibly use [[-c $1]] to look for character special device instead?

The following patch to the lib makes the tests pass here:
--- include/libtest.kshlib.orig 2013-06-20 00:00:37.923125499 +0000
+++ include/libtest.kshlib      2013-06-20 00:51:14.302027497 +0000
@@ -2682,9 +2682,8 @@
 #
 function is_physical_device #device
 {
-       typeset device=${1#/dev/}
+       [[ -c $1 ]]
 
-       $ECHO $device | $EGREP "^(ada|da|mlxd|myld|aacd|ided|twed)[0-9]+(s[0-9]+)?$" > /dev/null 2>&1
        return $?
 }

    Regards
    Steve

================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. 

In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster at multiplay.co.uk.