lots of missing declarations

[Alexander Best]

hi everybody,

i'm trying to successfully run 'make MAKE_JUST_KERNELS=yes tinderbox' with
the -Wmissing-declarations flag. apart from one issue in the xfs code, all
warnings issued by this flag come from inside the zfs sources. i've attached
a log file, which documents all of them.

is there any possibility these can be fixed and we can then permanently add
-Wmissing-declarations to CWARNFLAGS in sys/conf/kern.mk?

cheers.
alex

-- 
a13x
-------------- next part --------------
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/compat/opensolaris/kern/opensolaris_kobj.c:169: warning: no previous declaration for 'kobj_read_file_vnode'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/compat/opensolaris/kern/opensolaris_kobj.c:200: warning: no previous declaration for 'kobj_read_file_loader'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/os/callb.c:99: warning: no previous declaration for 'callb_init'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/os/callb.c:107: warning: no previous declaration for 'callb_fini'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/os/fm.c:1167: warning: no previous declaration for 'fm_ena_generate_cpu'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/zmod/zmod_subr.c:43: warning: no previous declaration for 'zcalloc'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/zmod/zmod_subr.c:59: warning: no previous declaration for 'zcfree'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/zmod/zmod_subr.c:70: warning: no previous declaration for 'zmemcpy'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/zmod/zmod_subr.c:76: warning: no previous declaration for 'zmemcmp'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/zmod/zmod_subr.c:82: warning: no previous declaration for 'zmemzero'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c:1651: warning: no previous declaration for 'arc_buf_free'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c:2183: warning: no previous declaration for 'arc_shrink'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/ddt.c:612: warning: no previous declaration for 'ddt_select_by_checksum'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c:806: warning: no previous declaration for 'dsl_pool_user_hold_create_obj'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_prop.c:550: warning: no previous declaration for 'dsl_prop_set_sync'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/gzip.c:41: warning: no previous declaration for 'gzip_compress'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/gzip.c:60: warning: no previous declaration for 'gzip_decompress'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/lzjb.c:51: warning: no previous declaration for 'lzjb_compress'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/lzjb.c:99: warning: no previous declaration for 'lzjb_decompress'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/metaslab.c:445: warning: no previous declaration for 'metaslab_pp_maxsize'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/metaslab.c:473: warning: no previous declaration for 'metaslab_ff_fragmented'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c:276: warning: no previous declaration for 'sa_layout_equal'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c:327: warning: no previous declaration for 'sa_attr_op'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c:1131: warning: no previous declaration for 'sa_build_idx_tab'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c:1195: warning: no previous declaration for 'sa_byteswap_cb'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c:1204: warning: no previous declaration for 'sa_byteswap'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c:1279: warning: no previous declaration for 'sa_evict'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c:1409: warning: no previous declaration for 'sa_lookup_impl'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/sha256.c:35: warning: no previous declaration for 'zio_checksum_SHA256'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c:4924: warning: no previous declaration for 'spa_vdev_set_common'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c:646: warning: no previous declaration for 'spa_aux_add'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c:664: warning: no previous declaration for 'spa_aux_remove'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c:684: warning: no previous declaration for 'spa_aux_exists'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c:709: warning: no previous declaration for 'spa_aux_activate'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c:1778: warning: no previous declaration for 'vdev_dtl_sync'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c:1987: warning: no previous declaration for 'vdev_remove'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c:963: warning: no previous declaration for 'vdev_uberblock_sync_list'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c:1072: warning: no previous declaration for 'vdev_label_sync_list'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c:91: warning: no previous declaration for 'vdev_queue_deadline_compare'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c:115: warning: no previous declaration for 'vdev_queue_offset_compare'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zap_micro.c:203: warning: no previous declaration for 'zap_name_alloc_uint64'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c:1998: warning: no previous declaration for 'zfs_release_sa_handle'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c:1447: warning: no previous declaration for 'zio_rewrite_gang'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c:1485: warning: no previous declaration for 'zio_free_gang'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c:1493: warning: no previous declaration for 'zio_claim_gang'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zle.c:38: warning: no previous declaration for 'zle_compress'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zle.c:68: warning: no previous declaration for 'zle_decompress'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zrlock.c:165: warning: no previous declaration for 'zrl_refcount'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/common/zfs/zfs_fletcher.c:136: warning: no previous declaration for 'fletcher_2_native'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/common/zfs/zfs_fletcher.c:153: warning: no previous declaration for 'fletcher_2_byteswap'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/common/zfs/zfs_fletcher.c:170: warning: no previous declaration for 'fletcher_4_native'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/common/zfs/zfs_fletcher.c:187: warning: no previous declaration for 'fletcher_4_byteswap'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/common/zfs/zfs_fletcher.c:205: warning: no previous declaration for 'fletcher_4_incremental_native'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/common/zfs/zfs_fletcher.c:228: warning: no previous declaration for 'fletcher_4_incremental_byteswap'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_acl.c:658: warning: no previous declaration for 'zfs_copy_ace_2_fuid'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c:583: warning: no previous declaration for 'zfsctl_freebsd_root_lookup'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c:919: warning: no previous declaration for 'zfsctl_snapdir_lookup'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c:1082: warning: no previous declaration for 'zfsctl_shares_lookup'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:350: warning: no previous declaration for 'zfs_secpolicy_write_perms'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:365: warning: no previous declaration for 'zfs_secpolicy_write_perms_ds'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:534: warning: no previous declaration for 'zfs_secpolicy_fsacl'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:550: warning: no previous declaration for 'zfs_secpolicy_rollback'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:557: warning: no previous declaration for 'zfs_secpolicy_send'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:618: warning: no previous declaration for 'zfs_secpolicy_share'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:631: warning: no previous declaration for 'zfs_secpolicy_smb_acl'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:1904: warning: no previous declaration for 'dataset_name_hidden'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c:4786: warning: no previous declaration for 'pool_status_check'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c:1175: warning: no previous declaration for 'zfs_unregister_callbacks'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c:2259: warning: no previous declaration for 'zfs_init'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c:2285: warning: no previous declaration for 'zfs_fini'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:1078: warning: no previous declaration for 'zfs_get_done'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:4526: warning: no previous declaration for 'zfs_inactive'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:6354: warning: no previous declaration for 'zfs_deleteextattr'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:6597: warning: no previous declaration for 'zfs_freebsd_getacl'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:6624: warning: no previous declaration for 'zfs_freebsd_setacl'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:6671: warning: no previous declaration for 'zfs_freebsd_aclcheck'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c:637: warning: no previous declaration for 'zvol_first_open'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c:677: warning: no previous declaration for 'zvol_last_close'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c:729: warning: no previous declaration for 'zvol_update_volsize'
/usr/git-freebsd-head/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c:1194: warning: no previous declaration for 'zvol_strategy'