zfs_getpages

[Martin Matuska]

As of this code:
+	for (i = 0; i < pcount; i++) {
+		if (i != reqpage) {
+			vm_page_lock(m[i]);
+			vm_page_free(m[i]);
+			vm_page_unlock(m[i]);
+		}
+	}

Do you think locking a page is sufficient to protect against a race?

As to our reference implementation it should be more like this:
+	vm_page_lock_queues();
+	for (i = 0; i < pcount; i++) {
+		if (i != reqpage) {
+			vm_page_free(m[i]);
+		}
+	}
+	vm_page_unlock_queues();

Cheers,
mm

Dňa 10. 10. 2010 10:38, Andriy Gapon  wrote / napísal(a):
> 
> Guys,
> 
> could you please review and or test the following addition to FreeBSD ZFS?
> http://people.freebsd.org/~avg/zfs-getpages.diff
> 
> Does it improve anything for you?
> Is it something worth committing?
>