PERFORCE change 90060 for review

[Robert Watson]

http://perforce.freebsd.org/chv.cgi?CH=90060

Change 90060 by rwatson at rwatson_sesame on 2006/01/21 12:10:52

	Don't take a pointer to an array.
	
	Don't return (void) -- gcc is fine with it, but is C?

Affected files ...

.. //depot/projects/trustedbsd/openbsm/libbsm/bsm_io.c#20 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_io.c#20 (text+ko) ====

@@ -551,7 +551,7 @@
 		break;
 
 	case AU_IPv6:
-		READ_TOKEN_BYTES(buf, len, &tok->tt.hdr32_ex.addr,
+		READ_TOKEN_BYTES(buf, len, tok->tt.hdr32_ex.addr,
 		    sizeof(tok->tt.hdr32_ex.addr), tok->len, err);
 		break;
 	}
@@ -2533,115 +2533,115 @@
 
 	switch(tok->id) {
 	case AUT_HEADER32:
-		return (print_header32_tok(outfp, tok, del, raw, sfrm));
+		print_header32_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_HEADER32_EX:
-		return (print_header32_ex_tok(outfp, tok, del, raw, sfrm));
+		print_header32_ex_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_HEADER64:
-		return (print_header64_tok(outfp, tok, del, raw, sfrm));
+		print_header64_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_HEADER64_EX:
-		return (print_header64_ex_tok(outfp, tok, del, raw, sfrm));
+		print_header64_ex_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_TRAILER:
-		return (print_trailer_tok(outfp, tok, del, raw, sfrm));
+		print_trailer_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_ARG32:
-		return (print_arg32_tok(outfp, tok, del, raw, sfrm));
+		print_arg32_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_ARG64:
-		return (print_arg64_tok(outfp, tok, del, raw, sfrm));
+		print_arg64_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_DATA:
-		return (print_arb_tok(outfp, tok, del, raw, sfrm));
+		print_arb_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_ATTR32:
-		return (print_attr32_tok(outfp, tok, del, raw, sfrm));
+		print_attr32_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_ATTR64:
-		return (print_attr64_tok(outfp, tok, del, raw, sfrm));
+		print_attr64_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_EXIT:
-		return (print_exit_tok(outfp, tok, del, raw, sfrm));
+		print_exit_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_EXEC_ARGS:
-		return (print_execarg_tok(outfp, tok, del, raw, sfrm));
+		print_execarg_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_EXEC_ENV:
-		return (print_execenv_tok(outfp, tok, del, raw, sfrm));
+		print_execenv_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_OTHER_FILE32:
-		return (print_file_tok(outfp, tok, del, raw, sfrm));
+		print_file_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_NEWGROUPS:
-		return (print_newgroups_tok(outfp, tok, del, raw, sfrm));
+		print_newgroups_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_IN_ADDR:
-		return (print_inaddr_tok(outfp, tok, del, raw, sfrm));
+		print_inaddr_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_IN_ADDR_EX:
-		return (print_inaddr_ex_tok(outfp, tok, del, raw, sfrm));
+		print_inaddr_ex_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_IP:
-		return (print_ip_tok(outfp, tok, del, raw, sfrm));
+		print_ip_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_IPC:
-		return (print_ipc_tok(outfp, tok, del, raw, sfrm));
+		print_ipc_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_IPC_PERM:
-		return (print_ipcperm_tok(outfp, tok, del, raw, sfrm));
+		print_ipcperm_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_IPORT:
-		return (print_iport_tok(outfp, tok, del, raw, sfrm));
+		print_iport_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_OPAQUE:
-		return (print_opaque_tok(outfp, tok, del, raw, sfrm));
+		print_opaque_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_PATH:
-		return (print_path_tok(outfp, tok, del, raw, sfrm));
+		print_path_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_PROCESS32:
-		return (print_process32_tok(outfp, tok, del, raw, sfrm));
+		print_process32_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_PROCESS32_EX:
-		return (print_process32ex_tok(outfp, tok, del, raw, sfrm));
+		print_process32ex_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_RETURN32:
-		return (print_return32_tok(outfp, tok, del, raw, sfrm));
+		print_return32_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_RETURN64:
-		return (print_return64_tok(outfp, tok, del, raw, sfrm));
+		print_return64_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_SEQ:
-		return (print_seq_tok(outfp, tok, del, raw, sfrm));
+		print_seq_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_SOCKET:
-		return (print_socket_tok(outfp, tok, del, raw, sfrm));
+		print_socket_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_SOCKINET32:
-		return (print_sock_inet32_tok(outfp, tok, del, raw, sfrm));
+		print_sock_inet32_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_SOCKUNIX:
-		return (print_sock_unix_tok(outfp, tok, del, raw, sfrm));
+		print_sock_unix_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_SUBJECT32:
-		return (print_subject32_tok(outfp, tok, del, raw, sfrm));
+		print_subject32_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_SUBJECT64:
-		return (print_subject64_tok(outfp, tok, del, raw, sfrm));
+		print_subject64_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_SUBJECT32_EX:
-		return (print_subject32ex_tok(outfp, tok, del, raw, sfrm));
+		print_subject32ex_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_TEXT:
-		return (print_text_tok(outfp, tok, del, raw, sfrm));
+		print_text_tok(outfp, tok, del, raw, sfrm);
 
 	case AUT_SOCKET_EX:
-		return (print_socketex32_tok(outfp, tok, del, raw, sfrm));
+		print_socketex32_tok(outfp, tok, del, raw, sfrm);
 
 	default:
-		return (print_invalid_tok(outfp, tok, del, raw, sfrm));
+		print_invalid_tok(outfp, tok, del, raw, sfrm);
 	}
 }
 
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message