PERFORCE change 91489 for review

[Robert Watson]

On Fri, 10 Feb 2006, Christian S.J. Peron wrote:

> http://perforce.freebsd.org/chv.cgi?CH=91489
>
> Change 91489 by csjp at csjp_xor on 2006/02/10 04:13:39
>
> 	Conditionally compile audit support into login(1) unless somebody has
> 	specified the NO_AUDIT flag in /etc/make.conf
>
> Affected files ...
>
> .. //depot/projects/trustedbsd/audit3/usr.bin/login/Makefile#8 edit
> .. //depot/projects/trustedbsd/audit3/usr.bin/login/login_audit.c#9 edit
>
> Differences ...
>
> ==== //depot/projects/trustedbsd/audit3/usr.bin/login/Makefile#8 (text+ko) ====
>
> @@ -7,10 +7,15 @@
> DPADD=	${LIBUTIL} ${LIBPAM}
> LDADD=	-lutil ${MINUSLPAM} -lbsm

Do you also need to conditionalize linking against libbsm here?  And I notice 
we're missing a ${LIBBSM} entry on the DPADD line also.

> +.if !defined(NO_AUDIT)
> +CFLAGS += -DUSE_BSM_AUDIT
> +.endif

Would it be better to have the use of the audit-related functions in login.c 
ifdef'd, and to conditionally compile login_audit.c?

Robert N M Watson
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message