PERFORCE change 84047 for review
Robert Watson
rwatson at FreeBSD.org
Wed Sep 21 11:07:20 GMT 2005
http://perforce.freebsd.org/chv.cgi?CH=84047
Change 84047 by rwatson at rwatson_zoo on 2005/09/21 11:06:45
Audit vnode data in getdirentries() only after necessary vnode
locking and Giant locking has occurred.
Affected files ...
.. //depot/projects/trustedbsd/audit3/sys/kern/vfs_syscalls.c#12 edit
Differences ...
==== //depot/projects/trustedbsd/audit3/sys/kern/vfs_syscalls.c#12 (text+ko) ====
@@ -3690,8 +3690,6 @@
if ((error = getvnode(td->td_proc->p_fd, uap->fd, &fp)) != 0)
return (error);
- AUDIT_ARG(vnpath, fp->f_vnode, ARG_VNODE1);
-
if ((fp->f_flag & FREAD) == 0) {
fdrop(fp, td);
return (EBADF);
@@ -3713,6 +3711,8 @@
auio.uio_resid = uap->count;
/* vn_lock(vp, LK_SHARED | LK_RETRY, td); */
vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, td);
+ AUDIT_ARG(vnpath, fp->f_vnode, ARG_VNODE1);
+
loff = auio.uio_offset = fp->f_offset;
#ifdef MAC
error = mac_check_vnode_readdir(td->td_ucred, vp);
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message
More information about the trustedbsd-cvs
mailing list