PERFORCE change 87554 for review

[Robert Watson]

http://perforce.freebsd.org/chv.cgi?CH=87554

Change 87554 by rwatson at rwatson_peppercorn on 2005/11/30 23:57:14

	Annotate a case of non-atomicity in the BSM flags code, where there
	is a potential race with another thread in similar code.

Affected files ...

.. //depot/projects/trustedbsd/openbsm/libbsm/bsm_flags.c#7 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_flags.c#7 (text+ko) ====

@@ -97,6 +97,11 @@
  *
  * XXXRW: If bits are specified that are not matched by any class, they are
  * omitted rather than rejected with EINVAL.
+ *
+ * XXXRW: This is not thread-safe as it relies on atomicity between
+ * setauclass() and sequential calls to getauclassent().  This could be
+ * fixed by iterating through the bitmask fields rather than iterating
+ * through the classes.
  */
 int
 getauditflagschar(char *auditstr, au_mask_t *masks, int verbose)
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message