PERFORCE change 35655 for review
John Baldwin
jhb at FreeBSD.org
Mon Aug 18 17:19:07 GMT 2003
On 16-Aug-2003 Pawel Jakub Dawidek wrote:
> On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote:
> +> - mode ~= cmask;
> +> + mode = mode &~ cmask;
>
> IMHO this is a style bug.
>
> This should be: mode = mode & ~cmask;
>
> On time, when I was tired, I've spend few minutes wondering why 'foo'
> after this operation isn't equal to 'foo - bar':)
>
> foo =- bar;
I prefer 'mode &= ~cmask' myself.
--
John Baldwin <jhb at FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message
More information about the trustedbsd-cvs
mailing list