PERFORCE change 35655 for review

Pawel Jakub Dawidek nick at garage.freebsd.pl
Sat Aug 16 16:43:00 GMT 2003


On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote:
+> -    mode ~= cmask;
+> +    mode = mode &~ cmask;

IMHO this is a style bug.

This should be: mode = mode & ~cmask;

On time, when I was tired, I've spend few minutes wondering why 'foo'
after this operation isn't equal to 'foo - bar':)

	foo =- bar;

-- 
Pawel Jakub Dawidek                       pawel at dawidek.net
UNIX Systems Programmer/Administrator     http://garage.freebsd.pl
Am I Evil? Yes, I Am!                     http://cerber.sourceforge.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 305 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/trustedbsd-cvs/attachments/20030816/dd6d8bbd/attachment.bin


More information about the trustedbsd-cvs mailing list