PERFORCE change 19023 for review

[John Baldwin]

On 10-Oct-2002 Chris Vance wrote:
> http://perforce.freebsd.org/p4db/chv.cgi?CH=19023
> 
> Change 19023 by cvance at cvance_laptop on 2002/10/10 07:14:36
> 
>       Fix bug.

I don't know if the style below is some NAI thing, but if you were using
style(9), then the second lines would be at fixed offsets and wouldn't
have to change.  This would result in a smaller, easier-to-read diff that
more obviously points out that you just added a single !.  Just something
to think about.  There are a lot of pratical things behind style(9).

> Affected files ...
> 
> .. //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 edit
> 
> Differences ...
> 
> ==== //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#8 (text+ko) ====
> 
> @@ -496,9 +496,9 @@
>                               struct vnode *vp = a->u.fs.vp;
>                               struct vattr va;
>                               if (VOP_ISLOCKED(vp, curthread) &&
> -                                 VOP_GETATTR(vp, &va,
> -                                             curthread->td_ucred,
> -                                             curthread)) {
> +                                 !VOP_GETATTR(vp, &va,
> +                                              curthread->td_ucred,
> +                                              curthread)) {
>                                       printf(" inode=%ld, fsid=%d, ftype=%d",
>                                              va.va_fileid, va.va_fsid, 
>                                              vp->v_type);

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message