PERFORCE change 15347 for review

[Chris Costello]

On Wednesday, July 31, 2002, Brian Feldman wrote:
> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=15347
> 
> Change 15347 by green at green_laptop_2 on 2002/07/31 14:31:24
> 
> 	mac_cred_canexec() no longer exists; use mac_check_vnode_exec().

   You misspelled "Unlock `p' when locking the vnode to
transition the credential" or something like that...

> Affected files ...
> 
> .. //depot/projects/trustedbsd/mac/sys/kern/kern_exec.c#28 edit
> 
> Differences ...
> 
>  #ifdef MAC
> +	PROC_UNLOCK(p);
>  	vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY, td);
>  	will_transition = mac_execve_will_transition(oldcred, imgp->vp);
>  	credential_changing |= will_transition;
>  	VOP_UNLOCK(imgp->vp, 0, td);
> +	PROC_LOCK(p);
>  #endif
>  
>  	if (credential_changing &&
> @@ -438,11 +440,13 @@
>  			change_egid(newcred, attr.va_gid);
>  #ifdef MAC
>  		if (will_transition) {
> +			PROC_UNLOCK(p);
>  			vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY, td);
>  			mac_execve_transition(oldcred, newcred, imgp->vp);
>  			VOP_UNLOCK(imgp->vp, 0, td);
> +			PROC_LOCK(p);
>  		}
> -#endif
> +#endif /* MAC */

-- 
Chris Costello                                <chris at FreeBSD.org>
FreeBSD Project                           http://www.FreeBSD.org/
TrustedBSD Project                     http://www.TrustedBSD.org/
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message