svn commit: r316932 - vendor/illumos/dist/lib/libzfs/common

[Andriy Gapon]

Author: avg
Date: Fri Apr 14 18:51:16 2017
New Revision: 316932
URL: https://svnweb.freebsd.org/changeset/base/316932

Log:
  6280 libzfs: unshare_one() could fail with EZFS_SHARENFSFAILED
  
  illumos/illumos-gate at d1672efb6feac57c42788e27f739dfa3c4f3baf7
  https://github.com/illumos/illumos-gate/commit/d1672efb6feac57c42788e27f739dfa3c4f3baf7
  
  https://www.illumos.org/issues/6280
    The unshare_one() in libzfs could fail with EZFS_SHARENFSFAILED at line 834
    here:
    831    /* make sure libshare initialized */
    832    if ((err = zfs_init_libshare(hdl, SA_INIT_SHARE_API)) != SA_OK) {
    833        free(mntpt);    /* don't need the copy anymore */
    834        return (zfs_error_fmt(hdl, EZFS_SHARENFSFAILED,
    835            dgettext(TEXT_DOMAIN, "cannot unshare '%s': %s"),
    836            name, _sa_errorstr(err)));
    837    }
    The correct error should be EZFS_UNSHARENFSFAILED instead.
  
  Reviewed by: Toomas Soome <tsoome at me.com>
  Reviewed by: Dan McDonald <danmcd at omniti.com>
  Reviewed by: Matthew Ahrens <mahrens at delphix.com>
  Approved by: Gordon Ross <gwr at nexenta.com>
  Author: Marcel Telka <marcel.telka at nexenta.com>

Modified:
  vendor/illumos/dist/lib/libzfs/common/libzfs_mount.c

Modified: vendor/illumos/dist/lib/libzfs/common/libzfs_mount.c
==============================================================================
--- vendor/illumos/dist/lib/libzfs/common/libzfs_mount.c	Fri Apr 14 18:49:44 2017	(r316931)
+++ vendor/illumos/dist/lib/libzfs/common/libzfs_mount.c	Fri Apr 14 18:51:16 2017	(r316932)
@@ -20,6 +20,7 @@
  */
 
 /*
+ * Copyright 2015 Nexenta Systems, Inc.  All rights reserved.
  * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
  * Copyright (c) 2014, 2016 by Delphix. All rights reserved.
  * Copyright 2016 Igor Kozhukhov <ikozhukhov at gmail.com>
@@ -914,7 +915,7 @@ unshare_one(libzfs_handle_t *hdl, const 
 	if ((err = zfs_init_libshare_arg(hdl, SA_INIT_ONE_SHARE_FROM_NAME,
 	    (void *)name)) != SA_OK) {
 		free(mntpt);	/* don't need the copy anymore */
-		return (zfs_error_fmt(hdl, EZFS_SHARENFSFAILED,
+		return (zfs_error_fmt(hdl, EZFS_UNSHARENFSFAILED,
 		    dgettext(TEXT_DOMAIN, "cannot unshare '%s': %s"),
 		    name, _sa_errorstr(err)));
 	}