svn commit: r271574 - user/ngie/add-pjdfstest/contrib/pjdfstest

Garrett Cooper yaneurabeya at gmail.com
Sun Sep 14 19:10:09 UTC 2014


> On Sep 14, 2014, at 4:21, Bruce Evans <brde at optusnet.com.au> wrote:
> 
>> On Sun, 14 Sep 2014, Garrett Cooper wrote:
>> 
>> Log:
>> Redo r271374 by using the right typecast for comparing i and ngroups
> 
> It is still quite broken (more broken than without the cast, since the
> cast breaks the warning).

Hi Bruce,
    I completely agree with your concerns. Since this is "contrib" code I wanted to make the smallest set of changes to make things compile, then push for the proper fix upstream.
    As an aside, is u_int completely portable; I personally prefer the longer forms of non-fixed width types, e.g. unsigned int, but that's my personal preference.
Thank you!
-Garrett


More information about the svn-src-user mailing list