svn commit: r221962 - in user/avg/xcpu/sys: kern sys

Andriy Gapon avg at FreeBSD.org
Sun May 15 16:53:58 UTC 2011


on 15/05/2011 19:19 Matthew Fleming said the following:
> On Sunday, May 15, 2011, Andriy Gapon <avg at freebsd.org> wrote:
>> on 15/05/2011 18:07 Ed Schouten said the following:
>>> Hey Andriy,
>>>
>>> * Andriy Gapon <avg at FreeBSD.org>, 20110515 16:32:
>>>> -    if (IS_PANIC_THREAD())
>>>> +    if (THREAD_PANICED())
>>>
>>> Shouldn't this be called THREAD_PANICKED(), with the k, instead?
>>>
>>
>> Yes, it should be.  Thank you.
> 
> Shouldn't it be TD_IS_PANIC[K]ED to match many of the other checks
> like TD_IS_IDLETHREAD?  Or perhaps to avoid a spelling change,
> TD_IS_INPANIC?

I like both of your proposals.  Where have you been before? :)
Ok, let's now settle on one best name and I will do another rename, that's easy
to do.

-- 
Andriy Gapon


More information about the svn-src-user mailing list