svn commit: r183951 - user/netchild/obsolete/src/libexec/tftpd

[Alexander Leidinger]

Quoting Rink Springer <rink at FreeBSD.org> (from Fri, 17 Oct 2008  
13:14:51 +0200):

> On Fri, Oct 17, 2008 at 09:51:38PM +1100, Edwin Groothuis wrote:
>> On Fri, Oct 17, 2008 at 11:24:33AM +0200, Alexander Leidinger wrote:
>> > Quoting Edwin Groothuis <edwin at mavetju.org> (from Fri, 17 Oct 2008
>> > 18:00:44 +1100):
>> >
>> > >On Thu, Oct 16, 2008 at 10:58:00AM +0000, Alexander Leidinger wrote:
>> > >>  The correct spelling is EACCES, not EACCESS.
>> > >[...]
>> > >>-	{ EACCESS,	"Access violation" },
>> > >>+	{ EACCES,	"Access violation" },
>> > >
>> > >I am not sure what you mean with this... What is exactly wrong with
>> > >the last S in EACCESS ?
>> >
>> > "man errno" does not list EACCESS, it only lists EACCES.
>>
>> True, but this is a TFTP error, not a system call return value.
>> See also the Appendix "Error Codes" of RFC1350.
>
> Wouldn't using definitions like 'TFTP_Exxx' make more sense, to prevent
> possible confusion as these are TFTP-specific error values?

Boy, this is not only confusing, it's also dangerous. There's more  
than only the EACCESS very near to named errno values. I fully agree  
with Rink, specially as the RFC only specifies error values, not  
symbolic names.

Bye,
Alexander.

-- 
http://www.Leidinger.net  Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org     netchild @ FreeBSD.org  : PGP ID = 72077137
Create problems for which only you have the answer.