svn commit: r304070 - svnadmin/conf

[Glen Barber]

On Sat, Aug 13, 2016 at 10:51:59PM -0700, Conrad Meyer wrote:
> On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett <juli at clockworksquid.com> wrote:
> > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber <gjb at freebsd.org> wrote:
> >> Quoting the original request to remove this, which I tend to agree:
> >>
> >> -------------------------- begin quoted text ---------------------------
> >>  The svn commit mail script uses some form of 'diff -p' (or 'svn diff
> >>  -x-p') to include function names at the top of each hunk.  The problem
> >>  is that diff gets it wrong more often than not, especially (but not
> >>  only) when functions are added or renamed, or outside a funciton, or in
> >>  headers, or in code that makes heavy use of macros, or in files that
> >>  aren't C-like source code: shell scripts, man pages, Makefiles...  All
> >>  it really does is clutter up the patch and mislead the reader.
> >> --------------------------- end quoted text ----------------------------
> >
> > :(
> >
> > I'm deeply skeptical that the described conditions add up to "more
> > often than not," and that tangible harm is done in those cases,
> > outweighing benefit added in the other, ostensibly rarer, case
> > (changes in ordinary C source files, which are actually fairly
> > abundant in FreeBSD.)
> 
> Exactly.  Yes, it gets it wrong sometimes.  But not enough to make it
> more harmful than beneficial.
> 

Reverted.  I won't deal with this topic further.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-svnadmin/attachments/20160814/68ce4b9f/attachment.sig>