svn commit: r367369 - stable/12/sys/dev/usb/storage

[Bjoern A. Zeeb]

Author: bz
Date: Thu Nov  5 11:33:23 2020
New Revision: 367369
URL: https://svnweb.freebsd.org/changeset/base/367369

Log:
  MFC r365334:
  
    umass: fix a cam_sim leak in error case
  
    While debugging a hang I noticed that in case of error in
    umass_cam_attach_sim() we miss a cam_sim_free() call.
    Added that to not leak resources.

Modified:
  stable/12/sys/dev/usb/storage/umass.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/usb/storage/umass.c
==============================================================================
--- stable/12/sys/dev/usb/storage/umass.c	Thu Nov  5 11:24:45 2020	(r367368)
+++ stable/12/sys/dev/usb/storage/umass.c	Thu Nov  5 11:33:23 2020	(r367369)
@@ -2105,6 +2105,7 @@ umass_cam_attach_sim(struct umass_softc *sc)
 
 	if (xpt_bus_register(sc->sc_sim, sc->sc_dev,
 	    sc->sc_unit) != CAM_SUCCESS) {
+		cam_sim_free(sc->sc_sim, /* free_devq */ TRUE);
 		mtx_unlock(&sc->sc_mtx);
 		return (ENOMEM);
 	}