svn commit: r361948 - in stable: 11/contrib/llvm-project/lld/ELF 12/contrib/llvm-project/lld/ELF

[Ed Maste]

Author: emaste
Date: Tue Jun  9 00:27:54 2020
New Revision: 361948
URL: https://svnweb.freebsd.org/changeset/base/361948

Log:
  MFC r361740: lld: Set DF_1_PIE for -pie
  
  DF_1_PIE originated from Solaris[1].
  
  GNU ld[2] sets the flag on non-Solaris platforms.
  
  It can help distinguish PIE from ET_DYN.
  eu-classify from elfutils uses this to recognize PIE[3].
  
  glibc uses this flag to reject dlopen'ing a PIE[4]
  
  [1] https://docs.oracle.com/cd/E36784_01/html/E36857/chapter6-42444.html
  [2] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=5fe2850dd96483f176858fd75c098313d5b20bc2
  [3] https://sourceware.org/git/?p=elfutils.git;a=commit;h=3f489b5c7c78df6d52f8982f79c36e9a220e8951
  [4] https://sourceware.org/bugzilla/show_bug.cgi?id=24323
  
  Sponsored by:	The FreeBSD Foundation

Modified:
  stable/11/contrib/llvm-project/lld/ELF/SyntheticSections.cpp
Directory Properties:
  stable/11/   (props changed)
  stable/11/contrib/llvm-project/lld/   (props changed)

Changes in other areas also in this revision:
Modified:
  stable/12/contrib/llvm-project/lld/ELF/SyntheticSections.cpp
Directory Properties:
  stable/12/   (props changed)

Modified: stable/11/contrib/llvm-project/lld/ELF/SyntheticSections.cpp
==============================================================================
--- stable/11/contrib/llvm-project/lld/ELF/SyntheticSections.cpp	Tue Jun  9 00:26:30 2020	(r361947)
+++ stable/11/contrib/llvm-project/lld/ELF/SyntheticSections.cpp	Tue Jun  9 00:27:54 2020	(r361948)
@@ -1315,6 +1315,8 @@ template <class ELFT> void DynamicSection<ELFT>::final
     dtFlags1 |= DF_1_NODELETE;
   if (config->zNodlopen)
     dtFlags1 |= DF_1_NOOPEN;
+  if (config->pie)
+    dtFlags1 |= DF_1_PIE;
   if (config->zNow) {
     dtFlags |= DF_BIND_NOW;
     dtFlags1 |= DF_1_NOW;