svn commit: r351992 - stable/12/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Sat Sep  7 11:24:29 2019
New Revision: 351992
URL: https://svnweb.freebsd.org/changeset/base/351992

Log:
  MFC r350254:
  
  Don't hold a mutex while calling sbwait. This was found by syzkaller.
  
  Submitted by:		rrs@
  Reported by:		markj@

Modified:
  stable/12/sys/netinet/sctp_output.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/netinet/sctp_output.c
==============================================================================
--- stable/12/sys/netinet/sctp_output.c	Sat Sep  7 11:22:24 2019	(r351991)
+++ stable/12/sys/netinet/sctp_output.c	Sat Sep  7 11:24:29 2019	(r351992)
@@ -13409,10 +13409,10 @@ skip_preblock:
 					    stcb,
 					    SCTP_OUTPUT_FROM_USR_SEND, SCTP_SO_LOCKED);
 				}
-				if (hold_tcblock == 1) {
-					SCTP_TCB_UNLOCK(stcb);
-					hold_tcblock = 0;
-				}
+			}
+			if (hold_tcblock == 1) {
+				SCTP_TCB_UNLOCK(stcb);
+				hold_tcblock = 0;
 			}
 			SOCKBUF_LOCK(&so->so_snd);
 			/*-