svn commit: r340940 - stable/12/sbin/route

[Eugene Grosbein]

Author: eugen
Date: Mon Nov 26 11:05:26 2018
New Revision: 340940
URL: https://svnweb.freebsd.org/changeset/base/340940

Log:
  MFC r339811: route(8): correctly return exit status when "-q" flag
  is used.
  
    Previously, route returned 1 in case of error  properly signalling
    failure but "route -q" it returned 0 for same case. Fix it.
  
  PR:		186333

Modified:
  stable/12/sbin/route/route.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sbin/route/route.c
==============================================================================
--- stable/12/sbin/route/route.c	Mon Nov 26 11:04:35 2018	(r340939)
+++ stable/12/sbin/route/route.c	Mon Nov 26 11:05:26 2018	(r340940)
@@ -1050,10 +1050,13 @@ newroute(int argc, char **argv)
 			}
 			printf("\n");
 		}
+	}
 
-		fibnum = 0;
-		TAILQ_FOREACH(fl, &fibl_head, fl_next) {
-			if (fl->fl_error != 0) {
+	fibnum = 0;
+	TAILQ_FOREACH(fl, &fibl_head, fl_next) {
+		if (fl->fl_error != 0) {
+			error = 1;
+			if (!qflag) {
 				printf("%s %s %s", cmd, (nrflags & F_ISHOST)
 				    ? "host" : "net", dest);
 				if (*gateway)
@@ -1087,7 +1090,6 @@ newroute(int argc, char **argv)
 					break;
 				}
 				printf(": %s\n", errmsg);
-				error = 1;
 			}
 		}
 	}