svn commit: r333503 - stable/11/sys/net

[John Baldwin]

On Friday, May 11, 2018 07:31:40 PM Jonathan T. Looney wrote:
> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd <shurd at freebsd.org> wrote:
> >
> > Author: shurd
> > Date: Fri May 11 20:40:26 2018
> > New Revision: 333503
> > URL: https://svnweb.freebsd.org/changeset/base/333503
> >
> > Log:
> >   MFC r333329, r333366, r333373
> >
> >   r333329: Fix off-by-one error requesting tx interrupt
> >   r333366: Cleanup queues when iflib_device_register fails
> >   r333373: Log iflib_tx_structures_setup failure in function
> >
> 
> Is this an acceptable style for MFC logs?
> 
> I'm asking because I actually prefer this to reading (or compiling) the
> concatenated log messages from several changes. However, I never knew it
> was acceptable to summarize like this. If it is, I'd like to know so I can
> adopt it for run-of-the-mill MFCs.

I prefer to summarize myself, but others have complained that you then
can't grep for strings used in the head commit log to determine if a
change has been MFC'd (assuming you don't have the head rev handy and
want to search by some name / string you remember).  In particular I
preferred doing a "squash" of fixup type commits when doing MFCs, but
I've relented to doing the full logs.

-- 
John Baldwin