svn commit: r314277 - in stable/10/usr.sbin/pw: . tests

[Baptiste Daroussin]

Author: bapt
Date: Sat Feb 25 19:28:49 2017
New Revision: 314277
URL: https://svnweb.freebsd.org/changeset/base/314277

Log:
  MFC r312644, r312650
  
  r312644:
  Readd a feature lost in pw(8) refactoring
  
  pw usermod foo -m
  
  It used to be able to (re)create the home directory if it didn't exists
  
  r312650:
  Really restore the old behaviour for pw usermod -m
  
  It again reinstall missing skel files without overwriting changed one
  Add a regression test about it
  
  PR:		216224
  Reported by:	ae

Modified:
  stable/10/usr.sbin/pw/psdate.c
  stable/10/usr.sbin/pw/pw_user.c
  stable/10/usr.sbin/pw/tests/pw_usermod.sh
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/usr.sbin/pw/psdate.c
==============================================================================
--- stable/10/usr.sbin/pw/psdate.c	Sat Feb 25 19:16:20 2017	(r314276)
+++ stable/10/usr.sbin/pw/psdate.c	Sat Feb 25 19:28:49 2017	(r314277)
@@ -41,12 +41,8 @@ static const char rcsid[] =
 static int
 numerics(char const * str)
 {
-	int             rc = isdigit((unsigned char)*str);
 
-	if (rc)
-		while (isdigit((unsigned char)*str) || *str == 'x')
-			++str;
-	return rc && !*str;
+	return (str[strspn(str, "0123456789x")] == '\0');
 }
 
 static int

Modified: stable/10/usr.sbin/pw/pw_user.c
==============================================================================
--- stable/10/usr.sbin/pw/pw_user.c	Sat Feb 25 19:16:20 2017	(r314276)
+++ stable/10/usr.sbin/pw/pw_user.c	Sat Feb 25 19:28:49 2017	(r314277)
@@ -1495,7 +1495,7 @@ pw_user_mod(int argc, char **argv, char 
 	intmax_t id = -1;
 	int ch, fd = -1;
 	size_t i, j;
-	bool quiet, createhome, pretty, dryrun, nis, edited, docreatehome;
+	bool quiet, createhome, pretty, dryrun, nis, edited;
 	bool precrypted;
 	mode_t homemode = 0;
 	time_t expire_days, password_days, now;
@@ -1505,7 +1505,7 @@ pw_user_mod(int argc, char **argv, char 
 	passwd = NULL;
 	class = nispasswd = NULL;
 	quiet = createhome = pretty = dryrun = nis = precrypted = false;
-	edited = docreatehome = false;
+	edited = false;
 
 	if (arg1 != NULL) {
 		if (arg1[strspn(arg1, "0123456789")] == '\0')
@@ -1706,8 +1706,6 @@ pw_user_mod(int argc, char **argv, char 
 			if (!createhome)
 				warnx("WARNING: home `%s' does not exist",
 				    pwd->pw_dir);
-			else
-				docreatehome = true;
 		} else if (!S_ISDIR(st.st_mode)) {
 			warnx("WARNING: home `%s' is not a directory",
 			    pwd->pw_dir);
@@ -1799,7 +1797,7 @@ pw_user_mod(int argc, char **argv, char 
 	 * that this also `works' for editing users if -m is used, but
 	 * existing files will *not* be overwritten.
 	 */
-	if (PWALTDIR() != PWF_ALT && docreatehome && pwd->pw_dir &&
+	if (PWALTDIR() != PWF_ALT && createhome && pwd->pw_dir &&
 	    *pwd->pw_dir == '/' && pwd->pw_dir[1]) {
 		if (!skel)
 			skel = cnf->dotdir;

Modified: stable/10/usr.sbin/pw/tests/pw_usermod.sh
==============================================================================
--- stable/10/usr.sbin/pw/tests/pw_usermod.sh	Sat Feb 25 19:16:20 2017	(r314276)
+++ stable/10/usr.sbin/pw/tests/pw_usermod.sh	Sat Feb 25 19:28:49 2017	(r314277)
@@ -253,6 +253,26 @@ user_mod_w_yes_body() {
 		$(atf_get_srcdir)/crypt $passhash "foo"
 }
 
+atf_test_case user_mod_m
+user_mod_m_body() {
+	populate_root_etc_skel
+
+	mkdir -p ${HOME}/home
+	mkdir -p ${HOME}/skel
+	echo "entry" > ${HOME}/skel/.file
+	atf_check -s exit:0 ${RPW} useradd foo
+	! test -d ${HOME}/home/foo || atf_fail "Directory should not have been created"
+	atf_check -s exit:0 ${RPW} usermod foo -m -k /skel
+	test -d ${HOME}/home/foo || atf_fail "Directory should have been created"
+	test -f ${HOME}/home/foo/.file || atf_fail "Skell files not added"
+	echo "entry" > ${HOME}/skel/.file2
+	atf_check -s exit:0 ${RPW} usermod foo -m -k /skel
+	test -f ${HOME}/home/foo/.file2 || atf_fail "Skell files not added"
+	echo > ${HOME}/home/foo/.file2
+	atf_check -s exit:0 ${RPW} usermod foo -m -k /skel
+	atf_check -s exit:0 -o inline:"\n" cat ${HOME}/home/foo/.file2
+}
+
 
 atf_init_test_cases() {
 	atf_add_test_case user_mod
@@ -275,4 +295,5 @@ atf_init_test_cases() {
 	atf_add_test_case user_mod_w_none
 	atf_add_test_case user_mod_w_random
 	atf_add_test_case user_mod_w_yes
+	atf_add_test_case user_mod_m
 }