svn commit: r299638 - stable/10/contrib/bsnmp/snmp_mibII

[Garrett Cooper]

Author: ngie
Date: Fri May 13 09:14:43 2016
New Revision: 299638
URL: https://svnweb.freebsd.org/changeset/base/299638

Log:
  MFC r298462:
  
  Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning
  
  This will also now detect error conditions with
  value->var.subs[sub - 1] == LEAF_ifPhysAddress where `string_get(..)`
  could fail if iifp->physaddr and/or iifp->physaddrlen were deemed
  invalid.
  
  CID: 1006551

Modified:
  stable/10/contrib/bsnmp/snmp_mibII/mibII_interfaces.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/contrib/bsnmp/snmp_mibII/mibII_interfaces.c
==============================================================================
--- stable/10/contrib/bsnmp/snmp_mibII/mibII_interfaces.c	Fri May 13 09:11:41 2016	(r299637)
+++ stable/10/contrib/bsnmp/snmp_mibII/mibII_interfaces.c	Fri May 13 09:14:43 2016	(r299638)
@@ -356,7 +356,7 @@ op_ifentry(struct snmp_context *ctx, str
 		value->v.oid = ifp->spec_oid;
 		break;
 	}
-	return (SNMP_ERR_NOERROR);
+	return (ret);
 }
 
 /*