svn commit: r310773 - in stable/11/sys: netinet netinet6
Rodney W. Grimes
freebsd-rwg at pdx.rh.CN85.dnsmgr.net
Thu Dec 29 14:38:34 UTC 2016
> Author: tuexen
> Date: Thu Dec 29 11:32:42 2016
> New Revision: 310773
> URL: https://svnweb.freebsd.org/changeset/base/310773
>
> Log:
> MFC r310590:
>
> Whitespace changes.
>
> The toolchain for processing the sources has been updated. No functional
> change.
What tool chain? It is still broken in at least 1 respect:
> /* now use the rest of the mbuf chain for the text */
> while (m_tmp != NULL) {
> if ((SCTP_BUF_NEXT(m_tmp) == NULL) && trailer) {
> - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset,
> + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset,
^^^^^^^^^^^^^^
> SCTP_BUF_LEN(m_tmp) - (trailer + m_offset));
> } else {
> - sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *) + m_offset,
> + sctp_hmac_update(hmac_algo, &ctx, mtod(m_tmp, uint8_t *)+m_offset,
^^^^^^^^^^^
> SCTP_BUF_LEN(m_tmp) - m_offset);
> }
>
... others errors of this type occur in this patch.
I think it would of been better to revert the old patch that messed up some comments
before creating this change as now there are other changes intermingled making the 2
changes inter-dependent.
Even with this small nit, I applaud the number of style(9) corrections!
--
Rod Grimes rgrimes at freebsd.org
More information about the svn-src-stable
mailing list