svn commit: r277767 - stable/10/sys/dev/acpica
Jung-uk Kim
jkim at FreeBSD.org
Mon Jan 26 19:25:36 UTC 2015
Author: jkim
Date: Mon Jan 26 19:25:35 2015
New Revision: 277767
URL: https://svnweb.freebsd.org/changeset/base/277767
Log:
MFC: r277579
Revert r216942. This commit was premature and caused too many complaints.
Modified:
stable/10/sys/dev/acpica/acpi_ec.c
Directory Properties:
stable/10/ (props changed)
Modified: stable/10/sys/dev/acpica/acpi_ec.c
==============================================================================
--- stable/10/sys/dev/acpica/acpi_ec.c Mon Jan 26 19:01:06 2015 (r277766)
+++ stable/10/sys/dev/acpica/acpi_ec.c Mon Jan 26 19:25:35 2015 (r277767)
@@ -623,7 +623,7 @@ EcGpeQueryHandler(void *Context)
struct acpi_ec_softc *sc = (struct acpi_ec_softc *)Context;
UINT8 Data;
ACPI_STATUS Status;
- int retry, sci_enqueued;
+ int retry;
char qxx[5];
ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
@@ -644,7 +644,6 @@ EcGpeQueryHandler(void *Context)
* that may arise from running the query from causing another query
* to be queued, we clear the pending flag only after running it.
*/
- sci_enqueued = sc->ec_sci_pend;
for (retry = 0; retry < 2; retry++) {
Status = EcCommand(sc, EC_COMMAND_QUERY);
if (ACPI_SUCCESS(Status))
@@ -684,14 +683,6 @@ EcGpeQueryHandler(void *Context)
device_printf(sc->ec_dev, "evaluation of query method %s failed: %s\n",
qxx, AcpiFormatException(Status));
}
-
- /* Reenable runtime GPE if its execution was deferred. */
- if (sci_enqueued) {
- Status = AcpiFinishGpe(sc->ec_gpehandle, sc->ec_gpebit);
- if (ACPI_FAILURE(Status))
- device_printf(sc->ec_dev, "reenabling runtime GPE failed: %s\n",
- AcpiFormatException(Status));
- }
}
/*
@@ -725,10 +716,9 @@ EcGpeHandler(ACPI_HANDLE GpeDevice, UINT
if ((EcStatus & EC_EVENT_SCI) && !sc->ec_sci_pend) {
CTR0(KTR_ACPI, "ec gpe queueing query handler");
Status = AcpiOsExecute(OSL_GPE_HANDLER, EcGpeQueryHandler, Context);
- if (ACPI_SUCCESS(Status)) {
+ if (ACPI_SUCCESS(Status))
sc->ec_sci_pend = TRUE;
- return (0);
- } else
+ else
printf("EcGpeHandler: queuing GPE query handler failed\n");
}
return (ACPI_REENABLE_GPE);
More information about the svn-src-stable
mailing list