svn commit: r199095 - stable/8/sys/dev/sym

[Ken Smith]

Author: kensmith
Date: Mon Nov  9 18:09:10 2009
New Revision: 199095
URL: http://svn.freebsd.org/changeset/base/199095

Log:
  MFC r198719:
  > While certain supported Symbios/LSI SCSI chips (532c896, 53c1000, 53c1010)
  > do support 64bit addresses, the current SCRIPTS code supports only 32bit
  > addresses causing data corruption for buffer addresses >4GB. This problem
  > affects 64bit machines with more than 4GB RAM or amd64 with 4GB and
  > memory hole remapping.
  > Work-around this problem with a bus_dma tag that requests bounce-buffers
  > for addresses >4GB. This causes some overhead, but given the maximum SCSI
  > bus speed of 160MB/s compared, the effect should hardly be noticeable.
  > The problem was reported by Mike Watters (mike at mwatters net) who also
  > verified that this fix cures the problem.
  >
  > Since this change is a NOOP on systems with less than 4GB RAM and fixes
  > data corruption (in RAM and on disk) on systems with more than 4GB, I hope
  > that this change is accepted for 8.0.
  
  Requested by:	Stefan Esser (se at freebsd dot org)[1]
  Reviewed by:	jhb, scottl
  
  [1] Stefan requested this be part of 8.0 but has been unavailable to do
      the MFC since submitting the request.  We want to get 8.0-RC3 started
      so I'm doing the merges with re@ hat on.

Modified:
  stable/8/sys/dev/sym/sym_hipd.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)

Modified: stable/8/sys/dev/sym/sym_hipd.c
==============================================================================
--- stable/8/sys/dev/sym/sym_hipd.c	Mon Nov  9 18:06:37 2009	(r199094)
+++ stable/8/sys/dev/sym/sym_hipd.c	Mon Nov  9 18:09:10 2009	(r199095)
@@ -8582,7 +8582,7 @@ sym_pci_attach(device_t dev)
 	 *  Allocate a tag for the DMA of user data.
 	 */
 	if (bus_dma_tag_create(np->bus_dmat, 1, (1<<24),
-				BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR,
+				BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR,
 				NULL, NULL,
 				BUS_SPACE_MAXSIZE, SYM_CONF_MAX_SG,
 				(1<<24), 0, busdma_lock_mutex, &np->mtx,