svn commit: r315261 - stable/9/sys/kern

Hans Petter Selasky hselasky at FreeBSD.org
Tue Mar 14 15:52:02 UTC 2017


Author: hselasky
Date: Tue Mar 14 15:52:01 2017
New Revision: 315261
URL: https://svnweb.freebsd.org/changeset/base/315261

Log:
  MFC r313941:
  
  Make sure the thread constructor and destructor eventhandlers are
  called for all threads belonging to a procedure. Currently the first
  thread in a procedure is kept around as an optimisation step and is
  never freed. Because the first thread in a procedure is never freed
  nor allocated, its destructor and constructor callbacks are never
  called which means per thread structures allocated by dtrace and the
  Linux emulation layers for example, might be present for threads which
  don't need these structures.
  
  This patch adds a thread construction and destruction call for the
  first thread in a procedure.
  
  Tested:			dtrace, linux emulation
  Reviewed by:		kib @
  Sponsored by:		Mellanox Technologies

Modified:
  stable/9/sys/kern/kern_proc.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/kern/kern_proc.c
==============================================================================
--- stable/9/sys/kern/kern_proc.c	Tue Mar 14 15:50:36 2017	(r315260)
+++ stable/9/sys/kern/kern_proc.c	Tue Mar 14 15:52:01 2017	(r315261)
@@ -178,11 +178,17 @@ static int
 proc_ctor(void *mem, int size, void *arg, int flags)
 {
 	struct proc *p;
+	struct thread *td;
 
 	p = (struct proc *)mem;
 	SDT_PROBE4(proc, kernel, ctor , entry, p, size, arg, flags);
 	EVENTHANDLER_INVOKE(process_ctor, p);
 	SDT_PROBE4(proc, kernel, ctor , return, p, size, arg, flags);
+	td = FIRST_THREAD_IN_PROC(p);
+	if (td != NULL) {
+		/* Make sure all thread constructors are executed */
+		EVENTHANDLER_INVOKE(thread_ctor, td);
+	}
 	return (0);
 }
 
@@ -207,6 +213,9 @@ proc_dtor(void *mem, int size, void *arg
 #endif
 		/* Free all OSD associated to this thread. */
 		osd_thread_exit(td);
+
+		/* Make sure all thread destructors are executed */
+		EVENTHANDLER_INVOKE(thread_dtor, td);
 	}
 	EVENTHANDLER_INVOKE(process_dtor, p);
 	if (p->p_ksi != NULL)


More information about the svn-src-stable-9 mailing list