svn commit: r296778 - stable/9/tools/regression/geom_concat

[Garrett Cooper]

Author: ngie
Date: Sat Mar 12 23:12:23 2016
New Revision: 296778
URL: https://svnweb.freebsd.org/changeset/base/296778

Log:
  MFstable/10 r296777:
  
  MFC r293434:
  
  - Use attach_md for memory disks so they can be tracked.
  - Add a geom_concat specific cleanup function and trap on that function at
    exit so things are cleaned up properly
  - Don't hardcode /tmp for temporary files, which violates the kyua sandbox

Modified:
  stable/9/tools/regression/geom_concat/conf.sh
  stable/9/tools/regression/geom_concat/test-1.t
  stable/9/tools/regression/geom_concat/test-2.t
Directory Properties:
  stable/9/   (props changed)
  stable/9/tools/   (props changed)
  stable/9/tools/regression/   (props changed)

Modified: stable/9/tools/regression/geom_concat/conf.sh
==============================================================================
--- stable/9/tools/regression/geom_concat/conf.sh	Sat Mar 12 23:11:08 2016	(r296777)
+++ stable/9/tools/regression/geom_concat/conf.sh	Sat Mar 12 23:12:23 2016	(r296778)
@@ -5,4 +5,11 @@ name="$(mktemp -u concat.XXXXXX)"
 class="concat"
 base=`basename $0`
 
+gconcat_test_cleanup()
+{
+	[ -c /dev/$class/$name ] && gconcat destroy $name
+	geom_test_cleanup
+}
+trap gconcat_test_cleanup ABRT EXIT INT TERM
+
 . `dirname $0`/../geom_subr.sh

Modified: stable/9/tools/regression/geom_concat/test-1.t
==============================================================================
--- stable/9/tools/regression/geom_concat/test-1.t	Sat Mar 12 23:11:08 2016	(r296777)
+++ stable/9/tools/regression/geom_concat/test-1.t	Sat Mar 12 23:12:23 2016	(r296778)
@@ -5,13 +5,11 @@
 
 echo '1..1'
 
-us=45
+us0=$(attach_md -t malloc -s 1M) || exit 1
+us1=$(attach_md -t malloc -s 2M) || exit 1
+us2=$(attach_md -t malloc -s 3M) || exit 1
 
-mdconfig -a -t malloc -s 1M -u $us || exit 1
-mdconfig -a -t malloc -s 2M -u `expr $us + 1` || exit 1
-mdconfig -a -t malloc -s 3M -u `expr $us + 2` || exit 1
-
-gconcat create $name /dev/md${us} /dev/md`expr $us + 1` /dev/md`expr $us + 2` || exit 1
+gconcat create $name /dev/$us0 /dev/$us1 /dev/$us2 || exit 1
 devwait
 
 # Size of created device should be 1MB + 2MB + 3MB.
@@ -23,8 +21,3 @@ if [ $size -eq 6291456 ]; then
 else
 	echo "not ok - Size is 6291456"
 fi
-
-gconcat destroy $name
-mdconfig -d -u $us
-mdconfig -d -u `expr $us + 1`
-mdconfig -d -u `expr $us + 2`

Modified: stable/9/tools/regression/geom_concat/test-2.t
==============================================================================
--- stable/9/tools/regression/geom_concat/test-2.t	Sat Mar 12 23:11:08 2016	(r296777)
+++ stable/9/tools/regression/geom_concat/test-2.t	Sat Mar 12 23:12:23 2016	(r296778)
@@ -5,18 +5,17 @@
 
 echo '1..1'
 
-us=45
 tsize=6
-src=`mktemp /tmp/$base.XXXXXX` || exit 1
-dst=`mktemp /tmp/$base.XXXXXX` || exit 1
+src=`mktemp $base.XXXXXX` || exit 1
+dst=`mktemp $base.XXXXXX` || exit 1
 
-dd if=/dev/random of=${src} bs=1m count=$tsize >/dev/null 2>&1
+us0=$(attach_md -t malloc -s 1M) || exit 1
+us1=$(attach_md -t malloc -s 2M) || exit 1
+us2=$(attach_md -t malloc -s 3M) || exit 1
 
-mdconfig -a -t malloc -s 1M -u $us || exit 1
-mdconfig -a -t malloc -s 2M -u `expr $us + 1` || exit 1
-mdconfig -a -t malloc -s 3M -u `expr $us + 2` || exit 1
+dd if=/dev/random of=${src} bs=1m count=$tsize >/dev/null 2>&1
 
-gconcat create $name /dev/md${us} /dev/md`expr $us + 1` /dev/md`expr $us + 2` || exit 1
+gconcat create $name /dev/$us0 /dev/$us1 /dev/$us2 || exit 1
 devwait
 
 dd if=${src} of=/dev/concat/${name} bs=1m count=$tsize >/dev/null 2>&1
@@ -28,8 +27,4 @@ else
 	echo "ok - md5 checksum comparison"
 fi
 
-gconcat destroy $name
-mdconfig -d -u $us
-mdconfig -d -u `expr $us + 1`
-mdconfig -d -u `expr $us + 2`
 rm -f ${src} ${dst}