svn commit: r291487 - stable/9/sys/modules/sfxge

[Andrew Rybchenko]

Author: arybchik
Date: Mon Nov 30 13:20:49 2015
New Revision: 291487
URL: https://svnweb.freebsd.org/changeset/base/291487

Log:
  MFC r283679
  
  sfxge: do not use DEBUG_FLAGS to enable extra debug checks
  
  DEBUG_FLAGS are set to DEBUG option value when kernel is built.
  For example, it is -g in GENERIC config to have debug symbols.
  Also DEBUG_FLAGS are used to determine if ctfconvert should keep
  debug symbols.
  Since we redefined DEBUG_FLAGS, debug symbols were always missing.
  ctfconvert complains about it during kernel build.
  It is incorrect to append DEBUG_FLAGS, since if DEBUG has no -g (or
  similar), we'll have no debug symbols and ctfconvert will complain.
  If it incorrect to always have -g in our DEBUG_FLAGS, since debug
  symbols presence should be controllable by kernel config.
  So, just add disabled by default addition of -DDEBUG=1 to CFLAGS.
  
  PR:             163775
  Sponsored by:   Solarflare Communications, Inc.

Modified:
  stable/9/sys/modules/sfxge/Makefile
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/dev/   (props changed)
  stable/9/sys/modules/   (props changed)

Modified: stable/9/sys/modules/sfxge/Makefile
==============================================================================
--- stable/9/sys/modules/sfxge/Makefile	Mon Nov 30 10:18:15 2015	(r291486)
+++ stable/9/sys/modules/sfxge/Makefile	Mon Nov 30 13:20:49 2015	(r291487)
@@ -20,6 +20,7 @@ SRCS+=	efx_vpd.c efx_wol.c
 SRCS+=	siena_mac.c siena_nic.c siena_nvram.c siena_phy.c
 SRCS+=	siena_sram.c siena_vpd.c 
 
-DEBUG_FLAGS= -g -DDEBUG=1
+# Extra debug checks
+#CFLAGS += -DDEBUG=1
 
 .include <bsd.kmod.mk>