svn commit: r273890 - stable/9/sys/dev/usb

[Hans Petter Selasky]

Author: hselasky
Date: Fri Oct 31 08:10:26 2014
New Revision: 273890
URL: https://svnweb.freebsd.org/changeset/base/273890

Log:
  MFC r250986:
  Fix some statical clang analyzer warnings.

Modified:
  stable/9/sys/dev/usb/usb_device.c
  stable/9/sys/dev/usb/usb_hub.c
  stable/9/sys/dev/usb/usb_msctest.c
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/dev/   (props changed)

Modified: stable/9/sys/dev/usb/usb_device.c
==============================================================================
--- stable/9/sys/dev/usb/usb_device.c	Fri Oct 31 08:06:21 2014	(r273889)
+++ stable/9/sys/dev/usb/usb_device.c	Fri Oct 31 08:10:26 2014	(r273890)
@@ -845,9 +845,6 @@ usb_config_parse(struct usb_device *udev
 			/* find maximum number of endpoints */
 			if (ep_max < temp)
 				ep_max = temp;
-
-			/* optimalisation */
-			id = (struct usb_interface_descriptor *)ed;
 		}
 	}
 

Modified: stable/9/sys/dev/usb/usb_hub.c
==============================================================================
--- stable/9/sys/dev/usb/usb_hub.c	Fri Oct 31 08:06:21 2014	(r273889)
+++ stable/9/sys/dev/usb/usb_hub.c	Fri Oct 31 08:10:26 2014	(r273890)
@@ -601,7 +601,6 @@ uhub_reattach_port(struct uhub_softc *sc
 
 	DPRINTF("reattaching port %d\n", portno);
 
-	err = 0;
 	timeout = 0;
 	udev = sc->sc_udev;
 	child = usb_bus_port_get_device(udev->bus,

Modified: stable/9/sys/dev/usb/usb_msctest.c
==============================================================================
--- stable/9/sys/dev/usb/usb_msctest.c	Fri Oct 31 08:06:21 2014	(r273889)
+++ stable/9/sys/dev/usb/usb_msctest.c	Fri Oct 31 08:10:26 2014	(r273890)
@@ -798,7 +798,6 @@ usb_msc_eject(struct usb_device *udev, u
 	if (sc == NULL)
 		return (USB_ERR_INVAL);
 
-	err = 0;
 	switch (method) {
 	case MSC_EJECT_STOPUNIT:
 		err = bbb_command_start(sc, DIR_IN, 0, NULL, 0,
@@ -840,6 +839,7 @@ usb_msc_eject(struct usb_device *udev, u
 		break;
 	default:
 		DPRINTF("Unknown eject method (%d)\n", method);
+		err = 0;
 		break;
 	}
 	DPRINTF("Eject CD command status: %s\n", usbd_errstr(err));