svn commit: r263452 - stable/9/sys/netgraph

Dimitry Andric dim at FreeBSD.org
Thu Mar 20 22:03:38 UTC 2014


Author: dim
Date: Thu Mar 20 22:03:37 2014
New Revision: 263452
URL: http://svnweb.freebsd.org/changeset/base/263452

Log:
  MFC r260046 (by glebius):
  
  Fix the parse type for NGM_LISTTYPES.
  
  Actually, text versions of generic commands are not used, since ngctl(8)
  uses binary messages for them. And to request a text command one needs
  a working ngctl(8). That's why the bug was never discovered. I'm pondering
  on removing the text support for generic commands.
  
  Found by:	dim with clang 3.4

Modified:
  stable/9/sys/netgraph/ng_base.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/netgraph/ng_base.c
==============================================================================
--- stable/9/sys/netgraph/ng_base.c	Thu Mar 20 21:57:10 2014	(r263451)
+++ stable/9/sys/netgraph/ng_base.c	Thu Mar 20 22:03:37 2014	(r263452)
@@ -473,7 +473,7 @@ static const struct ng_parse_type ng_gen
 	&ng_generic_linkinfo_array_type_info
 };
 
-DEFINE_PARSE_STRUCT_TYPE(typelist, TYPELIST, (&ng_generic_nodeinfoarray_type));
+DEFINE_PARSE_STRUCT_TYPE(typelist, TYPELIST, (&ng_generic_typeinfoarray_type));
 DEFINE_PARSE_STRUCT_TYPE(hooklist, HOOKLIST,
 	(&ng_generic_nodeinfo_type, &ng_generic_linkinfo_array_type));
 DEFINE_PARSE_STRUCT_TYPE(listnodes, LISTNODES,
@@ -549,7 +549,7 @@ static const struct ng_cmdlist ng_generi
 	  NGM_LISTTYPES,
 	  "listtypes",
 	  NULL,
-	  &ng_generic_typeinfo_type
+	  &ng_generic_typelist_type
 	},
 	{
 	  NGM_GENERIC_COOKIE,


More information about the svn-src-stable-9 mailing list