svn commit: r254897 - in stable/9: contrib/bind9 contrib/bind9/bin contrib/bind9/bin/check contrib/bind9/bin/confgen contrib/bind9/bin/dig contrib/bind9/bin/dig/include/dig contrib/bind9/bin/dnssec...

[Andre Albsmeier]

On Mon, 26-Aug-2013 at 07:17:42 +0000, Erwin Lansing wrote:
> Author: erwin
> Date: Mon Aug 26 07:17:41 2013
> New Revision: 254897
> URL: http://svnweb.freebsd.org/changeset/base/254897
> 
> Log:
>   MFC r254651:
>   
>   Update Bind to 9.9.3-P2

Thanks!

However, when enabling WITH_BIND_SIGCHASE in make.conf I get:

cc -O2 -pipe -DVERSION='"9.9.3-P2"' -DHAVE_CONFIG_H -D_REENTRANT -D_THREAD_SAFE -DOPENSSL -DUSE_MD5 -DNS_LOCALSTATEDIR='"/var"' -DNS_SYSCONFDIR='"/etc/namedb"' -DNAMED_CONFFILE='"/etc/namedb/named.conf"' -DRNDC_CONFFILE='"/etc/namedb/rndc.conf"' -DRNDC_KEYFILE='"/etc/namedb/rndc.key"' -I/src/src-9/usr.bin/dig/../../lib/bind -DDIG_SIGCHASE -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/bind9/include -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/dns/include/dst  -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/dns/include  -I/src/src-9/usr.bin/dig/../../lib/bind/dns -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/isccc/include -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/isccfg/include -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/isc/unix/include  -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/isc/pthreads/include  -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/isc/include  -I/src/src-9/usr.bin/dig/../../lib/bind/isc -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/lwres/unix/include  -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/lwres/include  -I/src/src-9/usr.bin/dig/../../lib/bind/lwres -I/src/src-9/usr.bin/dig/../../contrib/bind9/bin/dig/include -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/isc/x86_32/include -UENABLE_ALTQ -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wno-pointer-sign -c /src/src-9/usr.bin/dig/../../contrib/bind9/bin/dig/dighost.c
cc1: warnings being treated as errors
/src/src-9/usr.bin/dig/../../contrib/bind9/bin/dig/dighost.c: In function 'nameFromString':
/src/src-9/usr.bin/dig/../../contrib/bind9/bin/dig/dighost.c:4336: warning: passing argument 2 of 'isc__buffer_init' discards qualifiers from pointer target type
*** [dighost.o] Error code 1

How should we deal with this?

Changing the Makefiles of dig, host and nslookup to WARNS?=0
or patching dighost.c in contrib/bind9 directly?

--- dighost.c.ORI       2013-08-27 08:31:49.000000000 +0200
+++ dighost.c   2013-08-29 09:54:43.000000000 +0200
@@ -4333,7 +4333,7 @@
        REQUIRE(p_ret != NULL);
        REQUIRE(str != NULL);
 
-       isc_buffer_init(&buffer, str, len);
+       isc_buffer_init(&buffer, (char*)str, len);
        isc_buffer_add(&buffer, len);
 
        dns_fixedname_init(&fixedname);

Thanks,

	-Andre