svn commit: r232647 - stable/9/sys/fs/nullfs

Konstantin Belousov kib at FreeBSD.org
Wed Mar 7 08:08:36 UTC 2012


Author: kib
Date: Wed Mar  7 08:08:36 2012
New Revision: 232647
URL: http://svn.freebsd.org/changeset/base/232647

Log:
  MFC r232304:
  Document that null_nodeget() cannot take shared-locked lowervp due to
  insmntque() requirements.

Modified:
  stable/9/sys/fs/nullfs/null_subr.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/fs/nullfs/null_subr.c
==============================================================================
--- stable/9/sys/fs/nullfs/null_subr.c	Wed Mar  7 08:07:28 2012	(r232646)
+++ stable/9/sys/fs/nullfs/null_subr.c	Wed Mar  7 08:08:36 2012	(r232647)
@@ -209,7 +209,11 @@ null_nodeget(mp, lowervp, vpp)
 	struct vnode *vp;
 	int error;
 
-	ASSERT_VOP_LOCKED(lowervp, "lowervp");
+	/*
+	 * The insmntque1() call below requires the exclusive lock on
+	 * the nullfs vnode.
+	 */
+	ASSERT_VOP_ELOCKED(lowervp, "lowervp");
 	KASSERT(lowervp->v_usecount >= 1, ("Unreferenced vnode %p\n", lowervp));
 
 	/* Lookup the hash firstly */


More information about the svn-src-stable-9 mailing list