svn commit: r244499 - stable/9/usr.bin/fetch

[Eitan Adler]

Author: eadler
Date: Thu Dec 20 18:13:04 2012
New Revision: 244499
URL: http://svnweb.freebsd.org/changeset/base/244499

Log:
  MFC r244037:
  	Add check for failure of mkstemp and setenv.
  
  Approved by:	cperciva (implicit)

Modified:
  stable/9/usr.bin/fetch/fetch.c
Directory Properties:
  stable/9/usr.bin/fetch/   (props changed)

Modified: stable/9/usr.bin/fetch/fetch.c
==============================================================================
--- stable/9/usr.bin/fetch/fetch.c	Thu Dec 20 18:13:04 2012	(r244498)
+++ stable/9/usr.bin/fetch/fetch.c	Thu Dec 20 18:13:04 2012	(r244499)
@@ -604,7 +604,10 @@ fetch(char *URL, const char *path)
 			asprintf(&tmppath, "%.*s.fetch.XXXXXX.%s",
 			    (int)(slash - path), path, slash);
 			if (tmppath != NULL) {
-				mkstemps(tmppath, strlen(slash) + 1);
+				if (mkstemps(tmppath, strlen(slash) + 1) == -1) {
+					warn("%s: mkstemps()", path);
+					goto failure;
+				}
 				of = fopen(tmppath, "w");
 				chown(tmppath, sb.st_uid, sb.st_gid);
 				chmod(tmppath, sb.st_mode & ALLPERMS);
@@ -974,7 +977,8 @@ main(int argc, char *argv[])
 	if (v_tty)
 		fetchAuthMethod = query_auth;
 	if (N_filename != NULL)
-		setenv("NETRC", N_filename, 1);
+		if (setenv("NETRC", N_filename, 1) == -1)
+			err(1, "setenv: cannot set NETRC=%s", N_filename);
 
 	while (argc) {
 		if ((p = strrchr(*argv, '/')) == NULL)