svn commit: r219250 - stable/8/sys/dev/pci
John Baldwin
jhb at FreeBSD.org
Thu Mar 3 20:13:44 UTC 2011
Author: jhb
Date: Thu Mar 3 20:13:44 2011
New Revision: 219250
URL: http://svn.freebsd.org/changeset/base/219250
Log:
MFC 218968:
Properly handle BARs bigger than 4G. The '1' was treated as an int
causing the size calculation to be truncated to the size of an int
(32-bits on all current architectures).
Modified:
stable/8/sys/dev/pci/pci.c
Directory Properties:
stable/8/sys/ (props changed)
stable/8/sys/amd64/include/xen/ (props changed)
stable/8/sys/cddl/contrib/opensolaris/ (props changed)
stable/8/sys/contrib/dev/acpica/ (props changed)
stable/8/sys/contrib/pf/ (props changed)
Modified: stable/8/sys/dev/pci/pci.c
==============================================================================
--- stable/8/sys/dev/pci/pci.c Thu Mar 3 19:57:49 2011 (r219249)
+++ stable/8/sys/dev/pci/pci.c Thu Mar 3 20:13:44 2011 (r219250)
@@ -2499,13 +2499,13 @@ pci_add_map(device_t bus, device_t dev,
return (barlen);
}
- count = 1 << mapsize;
+ count = (pci_addr_t)1 << mapsize;
if (basezero || base == pci_mapbase(testval)) {
start = 0; /* Let the parent decide. */
end = ~0ULL;
} else {
start = base;
- end = base + (1 << mapsize) - 1;
+ end = base + count - 1;
}
resource_list_add(rl, type, reg, start, end, count);
@@ -3680,7 +3680,7 @@ pci_alloc_map(device_t dev, device_t chi
* another driver, which won't work.
*/
mapsize = pci_mapsize(testval);
- count = 1UL << mapsize;
+ count = (pci_addr_t)1 << mapsize;
if (RF_ALIGNMENT(flags) < mapsize)
flags = (flags & ~RF_ALIGNMENT_MASK) | RF_ALIGNMENT_LOG2(mapsize);
if (PCI_BAR_MEM(testval) && (testval & PCIM_BAR_MEM_PREFETCH))
More information about the svn-src-stable-8
mailing list