svn commit: r213002 - in stable/8: include lib/libc/gen

[Doug Barton]

On 9/23/2010 11:14 PM, Rui Paulo wrote:
> On 22 Sep 2010, at 22:08, Bruce Evans wrote:
>
>> On Wed, 22 Sep 2010, Rui Paulo wrote:
>>
>>> Log:
>>> MFC r197804 (rwatson):
>>>    Add basename_r(3) to complement basename(3).  basename_r(3) which accepts
>>>    a caller-allocated buffer of at least MAXPATHLEN, rather than using a
>>>    global buffer.
>>
>> MAXPATHLEN has been deprecated for more than 20 years.  Please don't use
>> it in new interfaces.  A few man pages, not including basename.3, have
>> been updated to spell it PATH_MAX (should be {PATH_MAX}).
>
> I'm not going to fix this because the interface will most likely change to something that doesn't require PATH_MAX. But thanks for pointing this out.

There are 2 possibilities. The first is that you do actually fix it 
soon, in which case the change Bruce asked for is harmless churn. This 
is common and accepted in HEAD. The other possibility (which happens to 
us all) is that the intended fixup never occurs, so the inappropriate 
code lingers and is ultimately forgotten. The potential cost in this 
case is much higher than the potential cost of some harmless churn. 
Bonus points if someone copies and pastes your code in the intervening 
period.


Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/