svn commit: r197474 - stable/8/lib/libkvm

[Brooks Davis]

Author: brooks
Date: Thu Sep 24 21:35:13 2009
New Revision: 197474
URL: http://svn.freebsd.org/changeset/base/197474

Log:
  MFC r196990:
  cr_groups is no longer embedded in struct ucred and is instead stored
  in a seperate array.  As such we need to use kvm_read rather than bcopy
  to populate the ki_groups field.
  
  This fixes a crash when running ps -ax on a coredump.
  
  Reported by:	brucec
  Tested by:	brucec
  MFC after:	3 days
  Approved by:	re@ (kib)

Modified:
  stable/8/lib/libkvm/   (props changed)
  stable/8/lib/libkvm/kvm_proc.c

Modified: stable/8/lib/libkvm/kvm_proc.c
==============================================================================
--- stable/8/lib/libkvm/kvm_proc.c	Thu Sep 24 21:32:56 2009	(r197473)
+++ stable/8/lib/libkvm/kvm_proc.c	Thu Sep 24 21:35:13 2009	(r197474)
@@ -151,7 +151,7 @@ kvm_proclist(kd, what, arg, p, bp, maxcn
 				kp->ki_cr_flags |= KI_CRF_GRP_OVERFLOW;
 			}
 				kp->ki_ngroups = ucred.cr_ngroups;
-			bcopy(ucred.cr_groups, kp->ki_groups,
+			kvm_read(kd, (u_long)ucred.cr_groups, kp->ki_groups,
 			    kp->ki_ngroups * sizeof(gid_t));
 			kp->ki_uid = ucred.cr_uid;
 			if (ucred.cr_prison != NULL) {