svn commit: r196355 - in stable/8/sys: . amd64/include/xen cam/ata
cddl/contrib/opensolaris contrib/dev/acpica contrib/pf
dev/xen/xenpci
Alexander Motin
mav at FreeBSD.org
Tue Aug 18 09:36:25 UTC 2009
Author: mav
Date: Tue Aug 18 09:36:25 2009
New Revision: 196355
URL: http://svn.freebsd.org/changeset/base/196355
Log:
Fix copy/paste bug, that requests data read during ATA device probe sequence
for ATA_SETFEATURES/ATA_SF_SETXFER command which by definition transfers no
data. Most of controllers are irrelevant to this bug, but some nVidia's
doesn't.
Tested on: current@
Approved by: re (kib)
Modified:
stable/8/sys/ (props changed)
stable/8/sys/amd64/include/xen/ (props changed)
stable/8/sys/cam/ata/ata_xpt.c
stable/8/sys/cddl/contrib/opensolaris/ (props changed)
stable/8/sys/contrib/dev/acpica/ (props changed)
stable/8/sys/contrib/pf/ (props changed)
stable/8/sys/dev/xen/xenpci/ (props changed)
Modified: stable/8/sys/cam/ata/ata_xpt.c
==============================================================================
--- stable/8/sys/cam/ata/ata_xpt.c Tue Aug 18 09:31:00 2009 (r196354)
+++ stable/8/sys/cam/ata/ata_xpt.c Tue Aug 18 09:36:25 2009 (r196355)
@@ -370,10 +370,10 @@ probestart(struct cam_periph *periph, un
cam_fill_ataio(ataio,
1,
probedone,
- /*flags*/CAM_DIR_IN,
- MSG_SIMPLE_Q_TAG,
- /*data_ptr*/(u_int8_t *)ident_buf,
- /*dxfer_len*/sizeof(struct ata_params),
+ /*flags*/CAM_DIR_NONE,
+ 0,
+ /*data_ptr*/NULL,
+ /*dxfer_len*/0,
30 * 1000);
ata_36bit_cmd(ataio, ATA_SETFEATURES, ATA_SF_SETXFER, 0,
ata_max_mode(ident_buf, ATA_UDMA6, ATA_UDMA6));
More information about the svn-src-stable-8
mailing list