svn commit: r330897 - in stable/11: bin/cat bin/chflags bin/chmod bin/cp bin/date bin/dd bin/df bin/domainname bin/echo bin/ed bin/hostname bin/kill bin/ln bin/ls bin/mkdir bin/mv bin/pax bin/ps bi...

[Eitan Adler]

On 28 March 2018 at 18:04, Allan Jude <allanjude at freebsd.org> wrote:
> On 2018-03-28 14:15, Oliver Pinter wrote:
>> Hi!
>>
>> This part of the MFC is wrong:
>>
>> https://svnweb.freebsd.org/base/stable/11/sys/sys/random.h?limit_changes=0&r1=330897&r2=330896&pathrev=330897
>>
>> Could you please MFC back the other random related changes too? Some
>> of them made by cem at .
>>
>> On 3/14/18, Eitan Adler <eadler at freebsd.org> wrote:
>>> Author: eadler
>>> Date: Wed Mar 14 03:19:51 2018
>>> New Revision: 330897
>>> URL: https://svnweb.freebsd.org/changeset/base/330897
>>>
>>> Log:
>>>   Partial merge of the SPDX changes
>>>
>>>   These changes are incomplete but are making it difficult
>>>   to determine what other changes can/should be merged.
>>>
>>>   No objections from:        pfg
>>>
> Am I missing something? If this MFC was supposed to be of the SPDX
> license tagging, why does it have any functional changes?
>
> Especially changes to random(4)?

This was my failure. I only spot checked & compile-checked the diff
since I expected all changes to be comments/SPDX.

However, I must have gotten carried away and included a few too many
revisions. Unfortunately some people have already merged fixes to my
failure and thus this can't be reverted as is without also reverting
those fixes.

That said, I should do that since this commit message is utterly wrong.


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams