svn commit: r331025 - in stable/11/sys: conf dev/efidev modules/efirt

[Tomoaki AOKI]

Hi.

This causes instant panic on loading efirt.ko at least for my ThinkPad
T420, while r330991 was OK.
Please MFC r330843 and r330868 ASAP. Otherwise, revert this for now
until at least r330843 becomes MFC'able.

On head, r330843 stopped panic on loading efirt.ko for me, but ATM,
running efibootmgr (calling UEFI runtime service) causes panic.
This is fixed by r330868. So I believe both should be MFC'ed.

Regards.


> Author: kevans
> Date: Thu Mar 15 20:29:48 2018
> New Revision: 331025
> URL: https://svnweb.freebsd.org/changeset/base/331025
> 
> Log:
>   MFC (partially) r326066, r326121: Add an EFI RTC Driver
>   
>   This is effectively a direct commit to stable/11 to avoid the arm64
bits, as
>   those are unfortunately not able to MFC'd.
>   
>   MFC r326066:
>   Add a driver for the EFI RTC. This uses the EFI Runtime Services to
query
>   the system time.
>   
>   MFC r326121:
>   Zero struct efi_tm before setting the needed values. We don't use the
dst
>   or timezone fields so ensure these are set.
> 
> Added:
>   stable/11/sys/dev/efidev/efirtc.c
>      - copied, changed from r326066, head/sys/dev/efidev/efirtc.c
> Modified:
>   stable/11/sys/conf/files
>   stable/11/sys/modules/efirt/Makefile
> Directory Properties:
>   stable/11/   (props changed)
> 
> Modified: stable/11/sys/conf/files
> ==============================================================================
> --- stable/11/sys/conf/files	Thu Mar 15 20:25:06 2018	(r331024)
> +++ stable/11/sys/conf/files	Thu Mar 15 20:29:48 2018	(r331025)
> @@ -1585,6 +1585,7 @@
> dev/ed/if_ed_pccard.c		optional ed pccard
> dev/ed/if_ed_pci.c		optional ed pci
> dev/efidev/efidev.c		optional efirt
> dev/efidev/efirt.c		optional efirt
> +dev/efidev/efirtc.c		optional efirt
> dev/eisa/eisa_if.m		standard
> dev/eisa/eisaconf.c		optional eisa
> dev/e1000/if_em.c		optional em \
> 
> Copied and modified: stable/11/sys/dev/efidev/efirtc.c (from r326066,
head/sys/dev/efidev/efirtc.c)
> ==============================================================================
> --- head/sys/dev/efidev/efirtc.c	Tue Nov 21 17:23:16 2017 (r326066, copy source)
>  +++ stable/11/sys/dev/efidev/efirtc.c	Thu Mar 15 20:29:48 2018	(r331025)
> @@ -116,6 +116,7 @@ efirtc_settime(device_t dev, struct timespec *ts) 
>  	clock_ts_to_ct(ts, &ct);
>  
> +	bzero(&tm, sizeof(tm));
>  	tm.tm_sec = ct.sec;
>  	tm.tm_min = ct.min;
>  	tm.tm_hour = ct.hour;
> 
> Modified: stable/11/sys/modules/efirt/Makefile
> ==============================================================================
> --- stable/11/sys/modules/efirt/Makefile	Thu Mar 15 20:25:06
2018	(r331024) 
> +++ stable/11/sys/modules/efirt/Makefile Thu Mar 15 20:29:48
2018	(r331025)
> @@ -5,6 +5,7 @@
>  
>  KMOD=	efirt
>  SRCS=	efirt.c efirt_machdep.c efidev.c
> -SRCS+=  device_if.h bus_if.h
> +SRCS+=	efirtc.c
> +SRCS+=  device_if.h bus_if.h clock_if.h
>  
>  .include <bsd.kmod.mk>

-- 
Tomoaki AOKI    <junchoon at dec.sakura.ne.jp>