svn commit: r314789 - stable/11/sys/dev/qlxgbe

Somayajulu, David David.Somayajulu at cavium.com
Mon Mar 6 21:06:22 UTC 2017


Hi Rodney,
I was worried about the same as well. The reason it looks funky is that the following two lines have a 8 spaces instead of a tab.
>          bus_dmamem_free(dma_buf->dma_tag, dma_buf->dma_b, dma_buf->dma_map);
>          bus_dma_tag_destroy(dma_buf->dma_tag);

While 
> +	bus_dmamap_unload(dma_buf->dma_tag, dma_buf->dma_map);
Uses a tab instead. 

Thanks
David S.

-----Original Message-----
From: Rodney W. Grimes [mailto:freebsd at pdx.rh.CN85.dnsmgr.net] 
Sent: Monday, March 06, 2017 12:53 PM
To: David C Somayajulu <davidcs at freebsd.org>
Cc: src-committers at freebsd.org; svn-src-all at freebsd.org; svn-src-stable at freebsd.org; svn-src-stable-11 at freebsd.org
Subject: Re: svn commit: r314789 - stable/11/sys/dev/qlxgbe

> Author: davidcs
> Date: Mon Mar  6 20:25:33 2017
> New Revision: 314789
> URL: https://svnweb.freebsd.org/changeset/base/314789
> 
> Log:
>   MFC r314062
>   add bus_dmamap_unload in ql_free_dmabuf()
> 
> Modified:
>   stable/11/sys/dev/qlxgbe/ql_os.c
> Directory Properties:
>   stable/11/   (props changed)
> 
> Modified: stable/11/sys/dev/qlxgbe/ql_os.c 
> ==============================================================================
> --- stable/11/sys/dev/qlxgbe/ql_os.c	Mon Mar  6 19:55:07 2017	(r314788)
> +++ stable/11/sys/dev/qlxgbe/ql_os.c	Mon Mar  6 20:25:33 2017	(r314789)
> @@ -735,6 +735,7 @@ ql_alloc_dmabuf_exit:
>  void
>  ql_free_dmabuf(qla_host_t *ha, qla_dma_t *dma_buf)  {
> +	bus_dmamap_unload(dma_buf->dma_tag, dma_buf->dma_map);
>          bus_dmamem_free(dma_buf->dma_tag, dma_buf->dma_b, dma_buf->dma_map);
>          bus_dma_tag_destroy(dma_buf->dma_tag);
>  }

That looks as if this file has incorrect leading white space?

-- 
Rod Grimes                                                 rgrimes at freebsd.org


More information about the svn-src-stable-11 mailing list